Add public API exports to embedding/__init__.py#4502
Open
Ashutosh0x wants to merge 1 commit into
Open
Conversation
The embedding module had an empty __init__.py, forcing users to import from api.py directly. Added exports for EmbeddingQuantizer and TiedEmbeddingQuantizer, consistent with the int4/__init__.py pattern. Partial fix for pytorch#4333 Test Plan: Follows the same pattern as int4/__init__.py. The exported classes exist in api.py and are the module's public API. This change was authored with the assistance of an AI coding assistant.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4502
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
torchao/prototype/quantization/embedding/__init__.pywas empty, forcing users to import fromapi.pydirectly (e.g.,from torchao.prototype.quantization.embedding.api import EmbeddingQuantizer).Added public API exports for
EmbeddingQuantizerandTiedEmbeddingQuantizer, consistent with theint4/__init__.pypattern. Users can now write:Partial fix for #4333 (item #6)
Test Plan
Follows the same pattern as
int4/__init__.py. The exported classes exist inapi.pyand are the module's public API.This change was authored with the assistance of an AI coding assistant.