-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Provide an additional --xla flag to be able to run this test on TPU if available #1415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fedebongio
wants to merge
2
commits into
pytorch:main
Choose a base branch
from
fedebongio:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−23
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,48 @@ | ||
| # Basic MNIST Example | ||
| # MNIST Example | ||
|
|
||
| Trains a ConvNet on the MNIST dataset using PyTorch. | ||
|
|
||
| ## Usage | ||
|
|
||
| ### Standard (CUDA / MPS / XPU) | ||
|
|
||
| ```bash | ||
| pip install -r requirements.txt | ||
| python main.py | ||
| # CUDA_VISIBLE_DEVICES=2 python main.py # to specify GPU id to ex. 2 | ||
| # or to run on CPU only: | ||
| python main.py --no-accel | ||
| ``` | ||
|
|
||
| ### TPU (via PyTorch/XLA) | ||
|
|
||
| ```bash | ||
| pip install torch torchvision | ||
| pip install 'torch_xla[tpu]' | ||
| python main.py --xla | ||
| ``` | ||
|
|
||
| For multi-device TPU training, see the [PyTorch/XLA multiprocessing guide](https://docs.pytorch.org/xla/master/learn/pytorch-on-xla-devices.html). | ||
|
|
||
| ### Options | ||
|
|
||
| ``` | ||
| usage: main.py [-h] [--batch-size N] [--test-batch-size N] [--epochs N] | ||
| [--lr LR] [--gamma M] [--no-accel] [--xla] [--dry-run] | ||
| [--seed S] [--log-interval N] [--save-model] | ||
|
|
||
| PyTorch MNIST Example | ||
|
|
||
| options: | ||
| -h, --help show this help message and exit | ||
| --batch-size N input batch size for training (default: 64) | ||
| --test-batch-size N input batch size for testing (default: 1000) | ||
| --epochs N number of epochs to train (default: 14) | ||
| --lr LR learning rate (default: 1.0) | ||
| --gamma M Learning rate step gamma (default: 0.7) | ||
| --no-accel disables accelerator | ||
| --xla enables XLA device (e.g. TPU). Requires torch_xla. | ||
| --dry-run quickly check a single pass | ||
| --seed S random seed (default: 1) | ||
| --log-interval N how many batches to wait before logging training status | ||
| --save-model For Saving the current Model | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does the optimizer need to change for xla?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great catch! I used this for debugging when was performing poorly on TPU, to then find out that the actual fix was replacing the deprecated xm.optimizer_step() with optimizer.step() + torch_xla.sync(), which correctly applies gradients in torch_xla 2.x. Adadelta works fine on XLA with the updated API. So removing this unnecesary fork. Thank you!