test: cover resuming engine with unknown epoch length#3786
Open
nightcityblade wants to merge 2 commits into
Open
test: cover resuming engine with unknown epoch length#3786nightcityblade wants to merge 2 commits into
nightcityblade wants to merge 2 commits into
Conversation
Collaborator
|
@nightcityblade resolve the conflict with master branch |
2c36a3c to
12c7b95
Compare
Contributor
Author
|
Rebased Validation run:
|
vfdev-5
reviewed
Jun 11, 2026
| assert state.epoch_length is None | ||
|
|
||
| state = engine.run(itertools.count(start=0), max_epochs=engine.state.epoch + 1) | ||
| assert state.epoch == 2 |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert state.epoch == 2 | |
| # TODO: engine bug that increments the epoch counter: https://github.com/pytorch/ignite/issues/1386 | |
| # Uncomment the check when fixed | |
| # assert state.epoch == 1 |
Contributor
Author
|
Addressed the inline suggestion in commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1331
Description:
Adds regression coverage for continuing an engine after
terminate()when the data iterator has unknownepoch_length.Check list: