-
Notifications
You must be signed in to change notification settings - Fork 131
Remove Recipe prefix from RecipeDefinition in Radius.Core/recipePacks #11760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
18
commits into
main
Choose a base branch
from
copilot/standardize-recipe-parameter-naming
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e1975c5
Initial plan
Copilot c56df78
Standardize recipe parameter naming: rename Parameters to RecipeParam…
Copilot 0ef75a0
Remove 'recipe' prefix from kind, location, and parameters fields in …
Copilot 9c7d970
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim 3b302df
Update remaining recipeKind/recipeLocation in TypeSpec examples and t…
Copilot 073ee92
Fix RecipeKind/RecipeLocation field refs in test_client_factory and p…
Copilot 33147f3
Fix remaining RecipeKind/RecipeLocation refs in recipepack.go and upd…
Copilot af7e7c3
Fix Bicep test files and design notes: recipeKind→kind, recipeLocatio…
Copilot 647345c
Revert out-of-scope extensibility design notes change and fix serde f…
Copilot 3c675db
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim 5152195
Add test coverage for renamed Kind/Location fields in test helpers an…
Copilot 79613b4
Remove Recipe prefix from data model, CLI labels, and all user-facing…
Copilot 6b6d774
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim 07dfcdd
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim 6361151
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim 554e3b6
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim a28f7cc
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
nicolejms 7fd5fc0
Merge branch 'main' into copilot/standardize-recipe-parameter-naming
Reshrahim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
12 changes: 6 additions & 6 deletions
12
pkg/corerp/api/v20250801preview/zz_generated_models_serde.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nithyatsu @Reshrahim do the labels also need to have the
Recipeprefix removed? e.g.Kind: string(*recipe.Kind),There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I asked Copilot to remove it across UX including CLI. @nithyatsu - Please validate if these are the right places