Default Kubernetes image pull policy for Radius chart#11852
Open
officialasishkumar wants to merge 2 commits into
Open
Default Kubernetes image pull policy for Radius chart#11852officialasishkumar wants to merge 2 commits into
officialasishkumar wants to merge 2 commits into
Conversation
Remove explicit imagePullPolicy settings from chart-managed Radius containers so Kubernetes applies its default behavior based on the rendered image tag. Add Helm unit coverage to guard against reintroducing explicit pull policies.\n\nFixes: radius-project#10769 Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
officialasishkumar
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Radius Helm chart to rely on Kubernetes’ default imagePullPolicy behavior (based on the resolved image tag) by removing explicitly-set imagePullPolicy fields from chart-managed workloads, and adds Helm unit tests to prevent regressions.
Changes:
- Remove explicit
imagePullPolicyfrom controller, dashboard, database, and pre-upgrade Job templates. - Add Helm unit coverage asserting
imagePullPolicyis omitted for those chart-managed containers. - Include the pre-upgrade Job template in the test suite’s rendered templates.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/Chart/tests/helpers_test.yaml | Adds a unit test to assert imagePullPolicy is not emitted and includes the pre-upgrade Job template in the suite. |
| deploy/Chart/templates/controller/deployment.yaml | Removes explicit imagePullPolicy from the controller container. |
| deploy/Chart/templates/dashboard/deployment.yaml | Removes explicit imagePullPolicy from the dashboard container. |
| deploy/Chart/templates/database/statefulset.yaml | Removes explicit imagePullPolicy from the database container. |
| deploy/Chart/templates/pre-upgrade/job.yaml | Removes explicit imagePullPolicy from the pre-upgrade Job container. |
zachcasper
approved these changes
May 12, 2026
brooke-hamilton
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11852 +/- ##
==========================================
+ Coverage 51.38% 51.40% +0.01%
==========================================
Files 716 716
Lines 45106 45106
==========================================
+ Hits 23178 23186 +8
+ Misses 19725 19721 -4
+ Partials 2203 2199 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Radius Helm chart explicitly set
imagePullPolicyon several chart-managed containers. This causedAlwayspulls for controller, dashboard, and pre-upgrade and an explicitIfNotPresentfor database instead of letting Kubernetes choose the default from the rendered image tag.This removes the explicit policy from controller, dashboard, database, and pre-upgrade templates and adds Helm unit coverage that those containers omit
imagePullPolicy. A render check confirms noimagePullPolicyfields are emitted when dashboard, database, and pre-upgrade are enabled.Type of change
Fixes: #10769
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.