Add rad app show/list/delete --preview#11935
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
2429f5a to
91219dd
Compare
There was a problem hiding this comment.
Pull request overview
Adds --preview support for selected rad app commands so they can operate on Radius.Core/applications using the v20250801preview API surface.
Changes:
- Adds preview implementations for
rad app show,rad app list, andrad app delete. - Wires the preview implementations behind the existing commands via
--preview. - Adds Radius.Core application fake client support and tests for preview app commands.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cmd/rad/cmd/root.go |
Wires preview app delete/list/show command routing. |
pkg/cli/test_client_factory/radius_core.go |
Adds fake ApplicationsServer support for Radius.Core tests. |
pkg/cli/cmd/app/show/preview/show.go |
Adds preview app show runner. |
pkg/cli/cmd/app/show/preview/show_test.go |
Tests preview app show behavior. |
pkg/cli/cmd/app/list/preview/list.go |
Adds preview app list runner. |
pkg/cli/cmd/app/list/preview/list_test.go |
Tests preview app list behavior. |
pkg/cli/cmd/app/delete/preview/delete.go |
Adds preview app delete runner and resource cleanup logic. |
pkg/cli/cmd/app/delete/preview/delete_test.go |
Tests preview app delete behavior. |
91219dd to
45efad1
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11935 +/- ##
==========================================
+ Coverage 51.71% 51.79% +0.08%
==========================================
Files 725 728 +3
Lines 45629 45897 +268
==========================================
+ Hits 23595 23772 +177
- Misses 19791 19861 +70
- Partials 2243 2264 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
45efad1 to
21613c9
Compare
Radius functional test overviewClick here to see the test run details
Test Status⌛ Building Radius and pushing container images for functional tests... |
Adds --preview flag support to rad app show, rad app list, and rad app delete commands. When --preview is passed, these commands operate against Radius.Core/applications resources via the v20250801preview API surface, instead of the default Applications.Core/applications resource type. The pr also adds comprehensive tests for the preview `rad app list` command in `pkg/cli/cmd/app/list/preview/list_test.go`, covering validation, output, and error handling. ## Type of change - This pull request adds or changes features of Radius and has an approved issue (#11675). Fixes: Part of #11675 ## Contributor checklist Please verify that the PR meets the following requirements, where applicable: - An overview of proposed schema changes is included in a linked GitHub issue. - [x] Yes - [ ] Not applicable - A design document is added or updated under `eng/design-notes/` in this repository, if new APIs are being introduced. - [ ] Yes - [x] Not applicable - The design document has been reviewed and approved by Radius maintainers/approvers. - [ ] Yes - [x] Not applicable - A PR for [resource-types-contrib](https://github.com/radius-project/resource-types-contrib/) is created, if resource types or recipes are affected by the changes in this PR. - [ ] Yes - [x] Not applicable - A PR for [dashboard](https://github.com/radius-project/dashboard/) is created, if the Radius Dashboard is affected by the changes in this PR. - [ ] Yes - [x] Not applicable - A PR for the [documentation repository](https://github.com/radius-project/docs) is created, if the changes in this PR affect the documentation or any user facing updates are made. - [ ] Yes - [x] Not applicable Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
Adds --preview flag support to rad app show, rad app list, and rad app delete commands. When --preview is passed, these commands operate against Radius.Core/applications resources via the v20250801preview API surface, instead of the default Applications.Core/applications resource type. The pr also adds comprehensive tests for the preview
rad app listcommand inpkg/cli/cmd/app/list/preview/list_test.go, covering validation, output, and error handling.Type of change
rad appcommands don't work for applications created by Radius.Core/applications type #11675).Fixes: Part of #11675
Contributor checklist
Please verify that the PR meets the following requirements, where applicable:
eng/design-notes/in this repository, if new APIs are being introduced.