Skip to content

Add rad app show/list/delete --preview#11935

Merged
lakshmimsft merged 1 commit into
mainfrom
feature/app-preview-crud
May 20, 2026
Merged

Add rad app show/list/delete --preview#11935
lakshmimsft merged 1 commit into
mainfrom
feature/app-preview-crud

Conversation

@lakshmimsft
Copy link
Copy Markdown
Contributor

@lakshmimsft lakshmimsft commented May 19, 2026

Adds --preview flag support to rad app show, rad app list, and rad app delete commands. When --preview is passed, these commands operate against Radius.Core/applications resources via the v20250801preview API surface, instead of the default Applications.Core/applications resource type. The pr also adds comprehensive tests for the preview rad app list command in pkg/cli/cmd/app/list/preview/list_test.go, covering validation, output, and error handling.

Type of change

Fixes: Part of #11675

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document is added or updated under eng/design-notes/ in this repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for resource-types-contrib is created, if resource types or recipes are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for dashboard is created, if the Radius Dashboard is affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable

Copilot AI review requested due to automatic review settings May 19, 2026 05:26
@lakshmimsft lakshmimsft requested review from a team as code owners May 19, 2026 05:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds --preview support for selected rad app commands so they can operate on Radius.Core/applications using the v20250801preview API surface.

Changes:

  • Adds preview implementations for rad app show, rad app list, and rad app delete.
  • Wires the preview implementations behind the existing commands via --preview.
  • Adds Radius.Core application fake client support and tests for preview app commands.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cmd/rad/cmd/root.go Wires preview app delete/list/show command routing.
pkg/cli/test_client_factory/radius_core.go Adds fake ApplicationsServer support for Radius.Core tests.
pkg/cli/cmd/app/show/preview/show.go Adds preview app show runner.
pkg/cli/cmd/app/show/preview/show_test.go Tests preview app show behavior.
pkg/cli/cmd/app/list/preview/list.go Adds preview app list runner.
pkg/cli/cmd/app/list/preview/list_test.go Tests preview app list behavior.
pkg/cli/cmd/app/delete/preview/delete.go Adds preview app delete runner and resource cleanup logic.
pkg/cli/cmd/app/delete/preview/delete_test.go Tests preview app delete behavior.

Comment thread cmd/rad/cmd/root.go
@lakshmimsft lakshmimsft force-pushed the feature/app-preview-crud branch from 91219dd to 45efad1 Compare May 19, 2026 05:31
@lakshmimsft lakshmimsft requested a review from sk593 May 19, 2026 05:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Unit Tests

    2 files  ± 0    429 suites  +6   7m 25s ⏱️ +2s
5 185 tests +40  5 183 ✅ +40  2 💤 ±0  0 ❌ ±0 
6 263 runs  +80  6 261 ✅ +80  2 💤 ±0  0 ❌ ±0 

Results for commit 21613c9. ± Comparison against base commit c2049c9.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 65.79926% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.79%. Comparing base (c2049c9) to head (21613c9).

Files with missing lines Patch % Lines
pkg/cli/test_client_factory/radius_core.go 0.00% 40 Missing ⚠️
pkg/cli/cmd/app/delete/preview/delete.go 75.80% 17 Missing and 13 partials ⚠️
pkg/cli/cmd/app/show/preview/show.go 75.47% 8 Missing and 5 partials ⚠️
pkg/cli/cmd/app/list/preview/list.go 80.43% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11935      +/-   ##
==========================================
+ Coverage   51.71%   51.79%   +0.08%     
==========================================
  Files         725      728       +3     
  Lines       45629    45897     +268     
==========================================
+ Hits        23595    23772     +177     
- Misses      19791    19861      +70     
- Partials     2243     2264      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread pkg/cli/cmd/app/delete/preview/delete.go
Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
@lakshmimsft lakshmimsft force-pushed the feature/app-preview-crud branch from 45efad1 to 21613c9 Compare May 20, 2026 22:55
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests Bot commented May 20, 2026

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 21613c9
Unique ID funcc2f7db34e5
Image tag pr-funcc2f7db34e5
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc2f7db34e5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc2f7db34e5
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc2f7db34e5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc2f7db34e5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc2f7db34e5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@lakshmimsft lakshmimsft merged commit 3d2720d into main May 20, 2026
59 checks passed
@lakshmimsft lakshmimsft deleted the feature/app-preview-crud branch May 20, 2026 23:31
DariuszPorowski pushed a commit that referenced this pull request May 20, 2026
Adds --preview flag support to rad app show, rad app list, and rad app
delete commands. When --preview is passed, these commands operate
against Radius.Core/applications resources via the v20250801preview API
surface, instead of the default Applications.Core/applications resource
type. The pr also adds comprehensive tests for the preview `rad app
list` command in `pkg/cli/cmd/app/list/preview/list_test.go`, covering
validation, output, and error handling.

## Type of change

- This pull request adds or changes features of Radius and has an
approved issue (#11675).

Fixes: Part of #11675

## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:

- An overview of proposed schema changes is included in a linked GitHub
issue.
    - [x] Yes
    - [ ] Not applicable
- A design document is added or updated under `eng/design-notes/` in
this repository, if new APIs are being introduced.
    - [ ] Yes
    - [x] Not applicable
- The design document has been reviewed and approved by Radius
maintainers/approvers.
    - [ ] Yes
    - [x] Not applicable
- A PR for
[resource-types-contrib](https://github.com/radius-project/resource-types-contrib/)
is created, if resource types or recipes are affected by the changes in
this PR.
    - [ ] Yes
    - [x] Not applicable
- A PR for [dashboard](https://github.com/radius-project/dashboard/) is
created, if the Radius Dashboard is affected by the changes in this PR.
    - [ ] Yes
    - [x] Not applicable
- A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made.
    - [ ] Yes
    - [x] Not applicable

Signed-off-by: lakshmimsft <ljavadekar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update rad app * commands with --preview flag

3 participants