Skip to content

WIP: Do deep copy of geomety info#1546

Open
kanbouchou wants to merge 3 commits into
productionfrom
do_deep_copy_of_geomety_info
Open

WIP: Do deep copy of geomety info#1546
kanbouchou wants to merge 3 commits into
productionfrom
do_deep_copy_of_geomety_info

Conversation

@kanbouchou

Copy link
Copy Markdown
Collaborator

No description provided.

@kanbouchou kanbouchou self-assigned this Feb 2, 2026
@rdiankov

rdiankov commented Feb 2, 2026

Copy link
Copy Markdown
Owner

This will slow things down, so not sure I can agree to this...
The caller should know that the geometry ptr will be used as is, so why can't this be solved on the caller side?

@kanbouchou

Copy link
Copy Markdown
Collaborator Author

This will slow things down, so not sure I can agree to this... The caller should know that the geometry ptr will be used as is, so why can't this be solved on the caller side?

@rdiankov yes, alternatively we can ask the caller side to make deep copy. But what do you think about AddGeometry's addToGroups option being true? I don't come up with a use case that someone wants to share same shared pointer among different extra geometry groups and _vgeometryinfos.

@kanbouchou kanbouchou changed the title Draft: Do deep copy of geomety info Do deep copy of geomety info Feb 3, 2026
@kanbouchou
kanbouchou requested a review from rdiankov February 3, 2026 05:08
@kanbouchou kanbouchou changed the title Do deep copy of geomety info WIP: Do deep copy of geomety info Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants