Skip to content

Fix GetName() for OSG viewr#1553

Open
ReinaKousaka wants to merge 2 commits into
rdiankov:productionfrom
ReinaKousaka:songheng-2604-fixOsgViewerName
Open

Fix GetName() for OSG viewr#1553
ReinaKousaka wants to merge 2 commits into
rdiankov:productionfrom
ReinaKousaka:songheng-2604-fixOsgViewerName

Conversation

@ReinaKousaka

@ReinaKousaka ReinaKousaka commented Apr 20, 2026

Copy link
Copy Markdown

For qtosg viewer, its implementation of GetName() is now missing. This MR fixes it and makes this behavior almost identical as qtcoin viewer

production branch


In [1]: env.GetViewer().GetName()
---------------------------------------------------------------------------
_OpenRAVEException                        Traceback (most recent call last)
Cell In[1], line 1
----> 1 env.GetViewer().GetName()

_OpenRAVEException: ('openrave (NotImplemented): [virtual const std::string& OpenRAVE::ViewerBase::GetName() const:186] not implemented', 'NotImplemented')

@rdiankov

Copy link
Copy Markdown
Owner

@cielavenir can you take a look?

@cielavenir

Copy link
Copy Markdown
Collaborator

ok, tested env.GetViewer().GetName() and env.GetViewer().SetName()

thank you for the patch~~

@ReinaKousaka

Copy link
Copy Markdown
Author

@cielavenir @rdiankov A little more background here: I tried using videoRecorder to save a batch of planning trajectory animations executed by a script, but neither the OSG nor the Coin viewer supports it. And I feel like fixing the videoRecord codebase would require large-scale changes, not just a few lines of modification.

@cielavenir

Copy link
Copy Markdown
Collaborator

@ReinaKousaka it is known that offscreen rendering is required, which I tested years ago but not on Debian 13 yet.

I guess using Xvfb and ffmpeg -f x11grab combo is better.

But still, title screen should be changeable (this pull request).

@cielavenir

Copy link
Copy Markdown
Collaborator

(test_kinematics.TestKinematics.test_bodybasic had flakiness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants