Fix GetName() for OSG viewr#1553
Open
ReinaKousaka wants to merge 2 commits into
Open
Conversation
Owner
|
@cielavenir can you take a look? |
Collaborator
|
ok, tested env.GetViewer().GetName() and env.GetViewer().SetName() thank you for the patch~~ |
cielavenir
approved these changes
Jul 15, 2026
Author
|
@cielavenir @rdiankov A little more background here: I tried using videoRecorder to save a batch of planning trajectory animations executed by a script, but neither the OSG nor the Coin viewer supports it. And I feel like fixing the videoRecord codebase would require large-scale changes, not just a few lines of modification. |
Collaborator
|
@ReinaKousaka it is known that offscreen rendering is required, which I tested years ago but not on Debian 13 yet. I guess using Xvfb and But still, title screen should be changeable (this pull request). |
Collaborator
|
(test_kinematics.TestKinematics.test_bodybasic had flakiness) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
qtosgviewer, its implementation ofGetName()is now missing. This MR fixes it and makes this behavior almost identical asqtcoinviewerproductionbranch