Implement StateMachine for plugin lifecycle management#2120
Draft
bramoosterhuis wants to merge 3 commits into
Draft
Implement StateMachine for plugin lifecycle management#2120bramoosterhuis wants to merge 3 commits into
bramoosterhuis wants to merge 3 commits into
Conversation
Contributor
bramoosterhuis
commented
May 12, 2026
bramoosterhuis
commented
- Introduced a StateMachine class to manage the lifecycle states of plugins, including DEACTIVATED, PRECONDITION, ACTIVATED, HIBERNATED, and UNAVAILABLE.
- Defined stable and transient states with clear guarantees for callbacks during state transitions.
- Added detailed documentation for state transitions, callback guarantees, reentrancy, and crash handling.
- Refactored existing plugin state handling to utilize the new StateMachine, improving clarity and maintainability.
- Updated the Service class to integrate the StateMachine and handle state change notifications.
- Removed redundant locks and streamlined the Evaluate method to leverage the StateMachine's re-evaluation capabilities.
- Introduced a StateMachine class to manage the lifecycle states of plugins, including DEACTIVATED, PRECONDITION, ACTIVATED, HIBERNATED, and UNAVAILABLE. - Defined stable and transient states with clear guarantees for callbacks during state transitions. - Added detailed documentation for state transitions, callback guarantees, reentrancy, and crash handling. - Refactored existing plugin state handling to utilize the new StateMachine, improving clarity and maintainability. - Updated the Service class to integrate the StateMachine and handle state change notifications. - Removed redundant locks and streamlined the Evaluate method to leverage the StateMachine's re-evaluation capabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.