Skip to content

fix: pass classNames.body.cell to VirtualCell in virtual mode #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afc163 merged 3 commits into from
May 8, 2026
+14 −6
Merged

fix: pass classNames.body.cell to VirtualCell in virtual mode #1487

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7de66e6
fix: pass classNames.body.cell to VirtualCell in virtual mode
gavanx May 7, 2026
de7fb33
fix: pass styles.body.cell to VirtualCell for virtual table parity
gavanx May 8, 2026
41d5882
fix: pass classNames.body.row and styles.body.row to RowComponent in …
gavanx May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/VirtualTable/BodyLine.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ const BodyLine = React.forwardRef<HTMLDivElement, BodyLineProps>((props, ref) =>
const { data, index, className, rowKey, style, extra, getHeight, ...restProps } = props;
const { record, indent, index: renderIndex } = data;

const { scrollX, flattenColumns, prefixCls, fixColumn, componentWidth } = useContext(
const { scrollX, flattenColumns, prefixCls, fixColumn, componentWidth, classNames } = useContext(
TableContext,
['prefixCls', 'flattenColumns', 'fixColumn', 'componentWidth', 'scrollX'],
['prefixCls', 'flattenColumns', 'fixColumn', 'componentWidth', 'scrollX', 'classNames'],
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the classNames fix, you should also extract styles from TableContext. This ensures that custom styles defined in the styles prop of the Table are also correctly applied to cells in virtual mode.

Suggested change
const { scrollX, flattenColumns, prefixCls, fixColumn, componentWidth, classNames } = useContext(
TableContext,
['prefixCls', 'flattenColumns', 'fixColumn', 'componentWidth', 'scrollX'],
['prefixCls', 'flattenColumns', 'fixColumn', 'componentWidth', 'scrollX', 'classNames'],
const { scrollX, flattenColumns, prefixCls, fixColumn, componentWidth, classNames, styles } = useContext(
TableContext,
['prefixCls', 'flattenColumns', 'fixColumn', 'componentWidth', 'scrollX', 'classNames', 'styles'],
);

);
const { getComponent } = useContext(StaticContext, ['getComponent']);

Expand Down Expand Up @@ -103,6 +103,7 @@ const BodyLine = React.forwardRef<HTMLDivElement, BodyLineProps>((props, ref) =>
return (
<VirtualCell
key={colIndex}
className={classNames?.body?.cell}
component={cellComponent}
rowInfo={rowInfo}
column={column}
Comment on lines +112 to 116
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While adding className, you should also pass style from styles.body.cell for consistency.

Additionally, it appears that several required props for VirtualCell (colIndex, indent, index, renderIndex, and record) are currently missing in this instantiation. These props are necessary for VirtualCell to correctly calculate cell properties (like fixed column offsets) and render data. Since they are available in the scope of BodyLine, they should be passed down.

Suggested change
className={classNames?.body?.cell}
component={cellComponent}
rowInfo={rowInfo}
column={column}
className={classNames?.body?.cell}
style={styles?.body?.cell}
component={cellComponent}
rowInfo={rowInfo}
column={column}
colIndex={colIndex}
indent={indent}
index={index}
renderIndex={renderIndex}
record={record}

Expand Down