fix: android avoid NPE in GoogleSigninButton on RN 0.79 old architecture#1491
Open
kashmiry wants to merge 1 commit intoreact-native-google-signin:masterfrom
Open
fix: android avoid NPE in GoogleSigninButton on RN 0.79 old architecture#1491kashmiry wants to merge 1 commit intoreact-native-google-signin:masterfrom
kashmiry wants to merge 1 commit intoreact-native-google-signin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an Android crash when rendering
GoogleSigninButtonon React Native 0.79+ with newArchEnabled=false (old architecture).On RN 0.79+, Android view property updates in this path call
delegate.setProperty(...)during view creation/update. Returningnullcauses aNullPointerException.Issue details:
#1490
Reproduction:
https://github.com/kashmiry/rn79GoogleSigninCrash