fix: allow OAuth and RHSSO auth to be cancelled (#23844)

[adietish]

fixes eclipse-che/che#23844

[coderabbitai]

Warning

Review limit reached

@adietish, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 54 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: f7ffdec1-4f73-4c66-99f2-1a3daf0bfa05

📥 Commits

Reviewing files that changed from the base of the PR and between 9f7b425 and 6c34d9b.

📒 Files selected for processing (17)

• src/main/kotlin/com/redhat/devtools/gateway/auth/session/AbstractAuthSessionManager.kt
• src/main/kotlin/com/redhat/devtools/gateway/auth/session/AuthSessionManager.kt
• src/main/kotlin/com/redhat/devtools/gateway/auth/session/BrowserLogin.kt
• src/main/kotlin/com/redhat/devtools/gateway/auth/session/OpenShiftAuthSessionManager.kt
• src/main/kotlin/com/redhat/devtools/gateway/auth/session/RedHatAuthSessionManager.kt
• src/main/kotlin/com/redhat/devtools/gateway/auth/session/SsoLoginException.kt
• src/main/kotlin/com/redhat/devtools/gateway/openshift/Cluster.kt
• src/main/kotlin/com/redhat/devtools/gateway/util/ExceptionUtils.kt
• src/main/kotlin/com/redhat/devtools/gateway/util/UrlUtils.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/DevSpacesServerStepView.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/AbstractAuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/AuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/ClientCertificateAuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/OpenShiftCredentialsAuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/OpenShiftOAuthAuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/RedHatSSOAuthenticationStrategy.kt
• src/main/kotlin/com/redhat/devtools/gateway/view/steps/auth/TokenAuthenticationStrategy.kt

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 1.08108% with 183 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.03%. Comparing base (71098f6) to head (6c34d9b).
⚠️ Report is 351 commits behind head on main.

Files with missing lines	Patch %	Lines
...gateway/auth/session/AbstractAuthSessionManager.kt	0.00%	65 Missing ⚠️
...steps/auth/OpenShiftOAuthAuthenticationStrategy.kt	0.00%	25 Missing ⚠️
...ateway/auth/session/OpenShiftAuthSessionManager.kt	0.00%	23 Missing ⚠️
...s/gateway/auth/session/RedHatAuthSessionManager.kt	0.00%	22 Missing ⚠️
...view/steps/auth/RedHatSSOAuthenticationStrategy.kt	0.00%	20 Missing ⚠️
...ools/gateway/view/steps/DevSpacesServerStepView.kt	0.00%	9 Missing ⚠️
...dhat/devtools/gateway/auth/session/BrowserLogin.kt	0.00%	8 Missing ⚠️
.../view/steps/auth/AbstractAuthenticationStrategy.kt	0.00%	5 Missing ⚠️
...devtools/gateway/auth/session/SsoLoginException.kt	0.00%	4 Missing ⚠️
...evtools/gateway/auth/session/AuthSessionManager.kt	0.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##            main     #311       +/-   ##
==========================================
+ Coverage   0.00%   22.03%   +22.03%     
==========================================
  Files          4      101       +97     
  Lines         26     4244     +4218     
  Branches       0      778      +778     
==========================================
+ Hits           0      935      +935     
- Misses        26     3190     +3164     
- Partials       0      119      +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.