Skip to content

ENG-9556: Remove url for breadcrumbs with no associated doc page#6591

Open
carlosabadia wants to merge 3 commits into
mainfrom
carlos/breadcrumbs-fix
Open

ENG-9556: Remove url for breadcrumbs with no associated doc page#6591
carlosabadia wants to merge 3 commits into
mainfrom
carlos/breadcrumbs-fix

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested review from a team and Alek99 as code owners June 1, 2026 11:41
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jun 1, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Jun 1, 2026

ENG-9556

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Jun 1, 2026

Greptile Summary

This PR prevents 404-linked breadcrumbs for doc categories (e.g. /ai, /hosting) that have no page of their own. _resolve_breadcrumb_href now returns None for unresolvable paths, and the breadcrumb builder renders those segments as plain <span> elements instead of broken links.

  • _resolve_breadcrumb_href return type changed to str | None; returns None when neither the bare path nor its overview child is registered.
  • breadcrumb splits styling into a shared base_class and adds hover styles only to actual links; a hardcoded "Ai""AI" label fix is included for the /ai segment.
  • Two new tests cover the non-clickable span behavior and the None-return case; lock-file updates bump vite to 8.0.14 and remove react-dropzone.

Confidence Score: 4/5

Safe to merge — the change narrows breadcrumb link rendering to only registered routes and falls back to plain text, which is strictly safer than the previous behaviour of linking to potentially non-existent pages.

The logic change is small and well-tested. The only open question is the single-entry label override for "AI"; other acronym segments would silently display incorrectly if added later, but nothing is broken today.

docs/app/reflex_docs/templates/docpage/docpage.py — the hardcoded label override

Important Files Changed

Filename Overview
docs/app/reflex_docs/templates/docpage/docpage.py Core change: _resolve_breadcrumb_href now returns None for unregistered paths; breadcrumb renders those as non-clickable spans. Adds a hardcoded "Ai"→"AI" label fix.
docs/app/tests/test_breadcrumbs.py Two new tests verify the None-return and non-clickable span behaviors; good coverage of the new logic.
docs/app/reflex.lock/package.json Removes react-dropzone dependency and bumps vite from 8.0.12 to 8.0.14.
docs/app/reflex.lock/bun.lock Lock file updated to reflect package.json changes: removes react-dropzone and associated packages, upgrades vite and rolldown.

Reviews (1): Last reviewed commit: "ENG-9556: Remove url for breadcrumbs wit..." | Re-trigger Greptile

Comment thread docs/app/reflex_docs/templates/docpage/docpage.py Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jun 1, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing carlos/breadcrumbs-fix (048dad3) with main (82f90c8)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants