Add weighted fair scheduling for vqueues via scope rules#5013
Open
PascalThesing wants to merge 1 commit into
Open
Add weighted fair scheduling for vqueues via scope rules#5013PascalThesing wants to merge 1 commit into
PascalThesing wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
experimental-enable-vqueues, dispatch capacity is proportional to aservice's queued key count: a service with 100K queued keys starves few-keyed
services (measured: ~50 batching keys at 0.05% dispatch share).
Changes
list rotate over scheduling groups (invocation scope, else service name);
weight N = N slots per cycle regardless of key count. Per-queue DRR inside
a group unchanged; service groups fixed at weight 1.
restate rules set <scope> --weight N(
UserLimits.scheduling_weight, shown inrules list/sys_rules).With
experimental-enable-scope-inheritance,ctx.callchildren inheritthe caller's scope — one rule governs the whole call chain.
Validation
115 tests (exact weighted ratios, work conservation, wire compatibility);
benchmark: one weight-10 rule → +52% throughput for the flooding service
while the starved batchers flush twice as often.