Render dimension URIs as links in pivot tables#9532
Draft
rohithreddykota wants to merge 1 commit into
Draft
Conversation
Flat pivot tables now request the computed `__rill_uri` measure for any row dimension whose spec defines a `uri` template, and render the cell with an external link icon on hover. Mirrors the existing leaderboard behavior so URIs work consistently across explore and pivot views.
AdityaHegde
requested changes
Jun 11, 2026
| config.time, | ||
| rowDimensionNames, | ||
| ); | ||
| if (uriField) { |
Collaborator
There was a problem hiding this comment.
Lets move this check a level above, that way we only branch based on uri field during column definition construction vs on every cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics view dimensions that define a
uritemplate render as clickable links in the explore leaderboard but not in pivot tables. This change brings parity for flat pivots.pivot-data-store.ts: For flat pivots,createTableCellQuerynow appendsgetURIRequestMeasure(...)for any row dimension whose spec hasuridefined — the same computed measure the leaderboard uses.pivot-column-definition.ts:getFlatColumnDefreads the<dim>__rill_urivalue from each row and rendersPivotDimensionCellviamakeHrefwhen a URI resolves.PivotDimensionCell.svelte: New cell component — renders the value with an external-link icon that appears on hover, matching the leaderboard's link affordance.Nested pivot tables are left unchanged; can be a follow-up if needed.
Checklist:
Developed in collaboration with Claude Code