feat(canvas): gracefully filter excluded fields based on metrics security policy#9549
Open
burnerlee wants to merge 1 commit into
Open
Conversation
…rity policy When a metrics view security policy excludes a measure or dimension, canvas components now silently drop the excluded fields instead of showing a ComponentError or stuck loading state. - KPI Grid: filters out excluded measures before rendering; shows only the KPIs the current user can access - Table (flat): filters inaccessible columns; only errors if no columns remain - Pivot: filters inaccessible measures/dimensions; only errors if nothing usable remains - Leaderboard: filters inaccessible measures/dimensions consistently - Pivot display now passes loading state to validator to avoid a brief "Metrics view not found" flash on initial load Closes rilldata#8850
247ba9d to
94ed2ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a metrics view security policy
excludes a measure or dimension, canvas components now silently drop those fields instead of showing aComponentErroror a stuck loading/floating UI.isLoadingstate to the schema validator to prevent a brief "Metrics view not found" error on initial loadCloses 8850
Checklist: