[RF][HS3] Accept "shapefactor" modifier type in HistFactory importer#21213
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Apr 27, 2026
Merged
[RF][HS3] Accept "shapefactor" modifier type in HistFactory importer#21213guitargeek merged 2 commits intoroot-project:masterfrom
guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 11h 2m 54s ⏱️ For more details on these failures, see this check. Results for commit 9abe2e9. ♻️ This comment has been updated with latest results. |
silverweed
previously requested changes
Feb 10, 2026
cburgard
force-pushed
the
shapesys-bugfixes
branch
from
df27679 to
c0c4c32
Compare
The HS3 importer only recognised "shapesys" for ParamHistFunc-based modifiers and rejected the more accurate "shapefactor" type with "modifier of unknown type 'shapefactor'". Accept both spellings, and allow the modifier's "vals" array to be empty (or absent) when "parameters" is provided, as is typical for unconstrained shape factors written by other HS3 producers (e.g. pyhf).
This avoids some unneeded RooStats dependency.
guitargeek
force-pushed
the
shapesys-bugfixes
branch
from
c0c4c32 to
9abe2e9
Compare
guitargeek
changed the title
guitargeek
approved these changes
Apr 26, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
LGTM! I have also added a unit test for the case that is now supported.
Contributor
|
/backport to 6.40 |
|
Preparing to backport PR #21213 to branch 6.40 requested by guitargeek |
|
This PR has been backported to branch 6.40: #22068 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HS3 importer only recognised "shapesys" for ParamHistFunc-based modifiers and rejected the more accurate "shapefactor" type with "modifier of unknown type 'shapefactor'". Accept both spellings, and allow the modifier's "vals" array to be empty (or absent) when "parameters" is provided, as is typical for unconstrained shape factors written by other HS3 producers (e.g. pyhf).