Skip to content

[cppyy] Set LowLevelView itemsize to sizeof(T) for fixed multidim arrays #21388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronj0 merged 3 commits into from
Feb 27, 2026
Merged

[cppyy] Set LowLevelView itemsize to sizeof(T) for fixed multidim arrays #21388

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf97f98
[cppyy] Set LowLevelView itemsize to sizeof(T) for fixed multidim arrays
aaronj0 Feb 26, 2026
336c543
[test] No longer use np.frombuffer to convert LowLevelView arrays to …
aaronj0 Feb 26, 2026
22b34ec
[cppyy] lowlevel view unittest for multidim fixed-length array to numpy
aaronj0 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bindings/pyroot/cppyy/CPyCppyy/src/LowLevelViews.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,8 +1093,9 @@ static inline CPyCppyy::LowLevelView* CreateLowLevelViewT(
llp->fConverter = llp->fElemCnv;
} else {
// multi-dim array; sub-views are projected by using more LLViews
view.len = nx * sizeof(void*);
view.itemsize = sizeof(void*);
const size_t elemsize = isfix ? sizeof(T) : sizeof(void*);
view.len = nx * elemsize;
view.itemsize = elemsize;
for (Py_ssize_t idim = 1; idim < view.ndim; ++idim)
view.shape[idim] = shape[idim];

Expand Down
Loading