Skip to content

Fix argument passing conventions in h2root. #21404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hageboeck merged 1 commit into from
Feb 27, 2026
+6 −10
Merged

Fix argument passing conventions in h2root. #21404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions main/src/h2root.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,7 @@ void MAIN__() {}

// As recommended in
// https://gcc.gnu.org/onlinedocs/gfortran/Argument-passing-conventions.html
#if __GNUC__ > 7
typedef size_t fortran_charlen_t;
#else
typedef int fortran_charlen_t;
#endif
using fortran_charlen_t = size_t;
Comment thread
hageboeck marked this conversation as resolved.

#else
# define hlimit HLIMIT
Expand Down Expand Up @@ -329,11 +325,11 @@ int main(int argc, char **argv)

int lun = 10;
#ifndef WIN32
// "px" is a string being changed to "pxc" in the fortran side; since it's a temporary on C's side,
// we need a buffer of at least 3 chars on Cs side, too. Predefine it as a extra variable "px " since that way
// the space will be replaced by 'c' on the preallocated memory, instead of appending a new char (new memory) to "px".
auto opt = PASSCHAR("px ");
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),opt,record_size,ier,7,strlen(file_in),2);
// Reminder: Argument passing convention is that string lengths go as hidden arguments
// at the end of the argument list.
constexpr auto chdir = "example";
constexpr auto opt = "px";
hropen(lun, chdir, file_in, opt, record_size, ier, strlen(chdir), strlen(file_in), strlen(opt));
#else
hropen(lun,PASSCHAR("example"),PASSCHAR(file_in),PASSCHAR("px"),record_size,ier);
#endif
Expand Down
Loading