[tmva][sofie] Add support for operators Not, IsNaN and IsInf#21412
Merged
lmoneta merged 3 commits intoroot-project:masterfrom Mar 3, 2026
Merged
[tmva][sofie] Add support for operators Not, IsNaN and IsInf#21412lmoneta merged 3 commits intoroot-project:masterfrom
lmoneta merged 3 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 2h 51m 16s ⏱️ For more details on these failures, see this check. Results for commit b03ae5c. |
Add new operators by grouoing them in the ROperator_Basic_Is class and in ParseBasicIs function
Fix also some bugs with the IsNaN and IsInf operators
Remove also some commented code in the NonZero operator
lmoneta
force-pushed
the
tmva_sofie_new_operator_devs
branch
from
b03ae5c to
508f906
Compare
sanjibansg
approved these changes
Mar 3, 2026
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes adds support with the Not, IsNaN and IsInf operators and corresponding tests