[Python] Explicitly drop ownership of arguments to TH2Poly::AddBin()#21531
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 8, 2026
Merged
[Python] Explicitly drop ownership of arguments to TH2Poly::AddBin()#21531guitargeek merged 1 commit intoroot-project:masterfrom
TH2Poly::AddBin()#21531guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
This follows up on 7ac08ad, ensuring the object ownership is also handled correctly in `TH2Poly::AddBin()`. This is motivated by usage of `TH2Poly` in CMSSW unit tests, and a ROOT unit test that covers the same usage pattern is now added as well.
Test Results 22 files 22 suites 3d 5h 55m 32s ⏱️ Results for commit d67620e. |
vepadulano
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on 7ac08ad, ensuring the object ownership is also handled correctly in
TH2Poly::AddBin().This is motivated by usage of
TH2Polyin CMSSW unit tests, and a ROOT unit test that covers the same usage pattern is now added as well.Spinoff from #13593