Bugfix: executor doesn't propagate exception from task that awaited a future (backport #1643)#1651
Open
mergify[bot] wants to merge 1 commit into
Open
Bugfix: executor doesn't propagate exception from task that awaited a future (backport #1643)#1651mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
… future (#1643) * Schedule the original task when task awaits a future Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Add MultiThreadedExecutor to test Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Add tests for awaiting a done future and task cancellation during await Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> * Removed unused variable Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> --------- Signed-off-by: Nadav Elkabets <elnadav12@gmail.com> (cherry picked from commit aac0ebb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1642
Changes
A task now registers itself on the awaited future via new
Future._add_waiting_task.The executor then dispatches the same
Taskobject and sees its exception throughhandler.exception()as intended.Future._callbacksnow holdsUnion[Callable, Task]_schedule_or_invoke_done_callbackshandlesTaskentries throughexecutor._call_task_in_next_spin._wait_for_ready_callbacksskips tasks that were cancelled or completed between being queued and being popped.warnings.warnfires if a waitingTaskis dropped because the executor weakref could not be resolved.This is an automatic backport of pull request Bugfix: executor doesn't propagate exception from task that awaited a future #1643 done by Mergify.