Fix Windows failures in test_sleep_multiple_concurrent_waiters#1660
Fix Windows failures in test_sleep_multiple_concurrent_waiters#1660nadavelkabets wants to merge 1 commit into
test_sleep_multiple_concurrent_waiters#1660Conversation
test_sleep_multiple_concurrent_waiters
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
|
@Mergifyio rebase |
…windows Signed-off-by: Nadav Elkabets <elnadav12@gmail.com>
|
Deprecation notice: This pull request comes from a fork and was rebased using |
8d2c20d to
87b96a7
Compare
✅ Branch has been successfully rebased |
|
Pulls: #1660 |
Summary
Fixes test from #1620
Asyncio's clock (monotonic) has 15ms accuracy on windows, causing this test to fail.
The failure is due to asyncio's behavior of waking timer calls one clock tick early, failing the assert in the test.
Test failure
https://ci.ros2.org/view/nightly/job/nightly_win_rel/lastCompletedBuild/testReport/rclpy.rclpy.test/test_async_clock/test_sleep_multiple_concurrent_waiters/