electrsd: set default features for bitreq

[tankyleo]

If and only if the download feature is set, bitreq is required. In that case the bitreq std feature is needed, so we enable default-features for bitreq to set the std feature. No other bitreq feature is enabled.

[tankyleo]

cc @tnull

[jamillambert]

The title and change don't match. I think the title is correct and the bitreq/std feature should only be enabled when download is by removing std from bitreq and adding instead to the download fearture:
download = ["bitcoin_hashes", "zip", "bitreq/std"]

[tankyleo]

The title and change don't match. I think the title is correct and the bitreq/std feature should only be enabled when download is by removing std from bitreq and adding instead to the download fearture: download = ["bitcoin_hashes", "zip", "bitreq/std"]

If we do this, then this applies to the https feature too right? So we would do: download = ["bitcoin_hashes", "zip", "bitreq/std", "bitreq/https"]

I would find this uglier, especially since only download uses bitreq, but let me know.

[jamillambert]

The title and change don't match. I think the title is correct and the bitreq/std feature should only be enabled when download is by removing std from bitreq and adding instead to the download fearture: download = ["bitcoin_hashes", "zip", "bitreq/std"]

If we do this, then this applies to the https feature too right? So we would do: download = ["bitcoin_hashes", "zip", "bitreq/std", "bitreq/https"]

I would find this uglier, especially since only download uses bitreq, but let me know.

Hmm, yeah, you could change the tile so it is correct instead. Removing default-features = false from bitreq also fixes the problem since the only default feature is std.

[tcharding]

While correct I also rekon this would be better:

bitreq = { version = "0.3.5", path = "../bitreq", optional = true, features = ["https"] }

[tankyleo]

Thanks for the review, done below

[tcharding]

Thanks Leo, I debugged this myself today and got lost wondering how the heck this got into master.

[jamillambert]

ACK adde75f

[tcharding]

ACK adde75f