Skip to content

Fix LLVM IR expectations for the autodiff generic test #156754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgasho wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −2
Open

Fix LLVM IR expectations for the autodiff generic test #156754

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dce3433
Fix LLVM IR expectations for the autodiff generic test
sgasho May 19, 2026
3c06aea
Clarify the return types in LLVM IR for autodiff generic test
sgasho May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tests/codegen-llvm/autodiff/generic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,17 @@ fn square<T: std::ops::Mul<Output = T> + Copy>(x: &T) -> T {
// F64-NEXT: ; Function Attrs: {{.*}}
// F64-NEXT: define internal {{.*}} void
// F64-NEXT: start:
// F64-NEXT: {{(tail )?}}call {{(fastcc )?}}void @diffe_{{.*}}(double {{.*}}, ptr {{.*}})
// F64-NEXT: ret void
// F64-NEXT: {{(tail )?}}call {{.*}} @diffe_{{.*}}
Copy link
Copy Markdown
Contributor Author

@sgasho sgasho May 19, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still learning what level of detail LLVM IR checks should usually assert.

Since the exact return type and arg types of the generated @diffe_ call seem somewhat fragile here, would it be better to avoid checking them?

Is it enough for this test to only check that a diffe_ function is called?

View changes since the review

Copy link
Copy Markdown
Contributor Author

@sgasho sgasho May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind

Clarify the return types in LLVM IR for autodiff generic test

// F64: ret void

// Ensure that `square::<f64>` is generated so that it can be differentiated

// F64-LABEL: ; generic::square::<f64>
// F64-NEXT: ; Function Attrs: {{.*}}
// F64-NEXT: define internal {{.*}} double
// F64-NEXT: start:
// F64-NOT: ret
// F64: fmul double

// Main-LABEL: ; generic::main
// Main: ; call generic::square::<f32>
Expand Down
Loading