Skip to content

Fix reborrow_info early return skipping field validation #156784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikow wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −2
Open

Fix reborrow_info early return skipping field validation #156784

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac006d
Fix reborrow_info early return skipping field validation
ikow May 20, 2026
fabfa33
Add .stderr file for reborrow_multi_field_validation test
ikow May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/rustc_hir_analysis/src/coherence/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,8 +563,8 @@ pub(crate) fn reborrow_info<'tcx>(
)
.is_ok()
{
// Field implements Reborrow.
return Ok(());
// Field implements Reborrow, check remaining fields.
continue;
}

// Field does not implement Reborrow: it must be Copy.
Expand Down
15 changes: 15 additions & 0 deletions tests/ui/reborrow/reborrow_multi_field_validation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#![feature(reborrow)]

use std::marker::Reborrow;

// Regression test: `reborrow_info` must validate ALL data fields,
// not just stop at the first Reborrow field.

struct Bad<'a> {
first: &'a mut i32,
second: String, //~ ERROR the trait bound `String: Copy` is not satisfied
Copy link
Copy Markdown
Contributor

@dingxiangfei2009 dingxiangfei2009 May 20, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ./x t tests/ui/reborrow/reborrow_multi_field_validation.rs --bless once.

View changes since the review

}

impl<'a> Reborrow for Bad<'a> {}

fn main() {}
Loading