Added implementation on `set_permissions_nofollow` for all primary platforms by asder8215 · Pull Request #158168 · rust-lang/rust

asder8215 · 2026-06-20T06:51:38Z

For context, this PR is related to the tracking issue for std::fs::set_permissions_nofollow. This PR does a few different things:

Windows support is provided for std::fs::set_permissions_nofollow. On Windows, it uses OpenOptions::open with the custom flag FILE_FLAG_OPEN_REPARSE_POINT enabled and then sets the permissions on the reparse point directly. All other platforms (hermit, motor, solid, uefi, etc.) defer to what fs::set_permissions does since symlinks aren't supported on those platforms, so they effectively do the same thing.
The implementation for Unix was modified to use fchmodat instead of doing two separate calls (open and then fchmod via OpenOptions).
Because the previous implementations actually used fchmod instead of chmod underneath the hood (as that's what File::set_permissions, which is not to be confused with fs::set_permissions as that does use chmod, does underneath the hood), it actually had some incorrect documentation about the error returned by fchmod on symlinks. Instead of io::ErrorKind::FilesystemLoop, it returns io::ErrorKind::InvalidInput. You can read the documentation for fchmod. fchmodat does effectively the same thing as the open + fchmod combo, but it does return a different error, io::ErrorKind::Unsupported, that makes more sense. Regardless, I corrected the documentation for std::fs::set_permissions_nofollow and added a lot more clarifying information.
A test case has been added to verify if set_permissions_nofollow is operating correctly.

cc @ChrisDenton and @lolbinarycat

rustbot · 2026-06-20T06:51:42Z

r? @clarfonthey

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 12 candidates
Random selection from Darksonn, Mark-Simulacrum, clarfonthey, jhpratt

clarfonthey · 2026-06-20T12:09:10Z

 }

+pub fn set_perm_nofollow(path: &Path, perm: FilePermissions) -> io::Result<()> {
+    set_perm(path, perm)


Similar to UEFI, I would swap the method bodies here, so that set_perm defers to set_perm_nofollow plus a comment that says symlinks aren't supported.

View changes since the review

clarfonthey · 2026-06-20T12:15:58Z

@rustbot author

CI failure appears to be a simple typo but I also left some feedback on other stuff to fix. Otherwise, implementation looks good, although I would add an extra comment on the tracking issue once this is merged to have some Windows folks double-check that opening all reparse points in this method doesn't do anything we don't want, since that technically includes more than just symlinks. It should work in pretty much all normal use cases, just want to double-check the edge cases before stabilisation.

rustbot · 2026-06-20T12:16:02Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms try-job: dist-various-1

JonathanBrouwer · 2026-06-24T21:01:48Z

@bors try jobs=dist-various-1

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms try-job: dist-various-1

rust-bors · 2026-06-24T22:31:03Z

☀️ Try build successful (CI)
Build commit: a021ffd (a021ffd405b26c9f81a8df8f6000e8aa9487614e)
Base parent: f28ac76 (f28ac764c36004fa6a6e098d15b4016a838c13c6)

clarfonthey · 2026-06-29T17:46:42Z

@bors r+ rollup=iffy

Didn't actually run dist-various-2, but going to say this is probably fine now. Looks like all the potential issues have been covered, but it's still multi-platform code.

rust-bors · 2026-06-29T17:50:01Z

📌 Commit dcc21d6 has been approved by clarfonthey

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@ChrisDenton

…nofollow, r=clarfonthey Added implementation on `set_permissions_nofollow` for all primary platforms For context, this PR is related to the tracking issue for [`std::fs::set_permissions_nofollow`](rust-lang#141607). This PR does a few different things: * Windows support is provided for `std::fs::set_permissions_nofollow`. On Windows, it uses `OpenOptions::open` with the custom flag `FILE_FLAG_OPEN_REPARSE_POINT` enabled and then sets the permissions on the reparse point directly. All other platforms (hermit, motor, solid, uefi, etc.) defer to what `fs::set_permissions` does since symlinks aren't supported on those platforms, so they effectively do the same thing. * The implementation for Unix was modified to use [`fchmodat`](https://linux.die.net/man/2/fchmodat) instead of doing two separate calls (`open` and then `fchmod` via `OpenOptions`). * Because the previous implementations actually used `fchmod` instead of `chmod` underneath the hood (as that's what `File::set_permissions`, which is not to be confused with `fs::set_permissions` as that does use `chmod`, does underneath the hood), it actually had some incorrect documentation about the error returned by `fchmod` on symlinks. Instead of `io::ErrorKind::FilesystemLoop`, it returns `io::ErrorKind::InvalidInput`. You can read the documentation for [`fchmod`](https://pubs.opengroup.org/onlinepubs/009696699/functions/fchmod.html). `fchmodat` does effectively the same thing as the `open` + `fchmod` combo, but it does return a different error, `io::ErrorKind::Unsupported`, that makes more sense. Regardless, I corrected the documentation for `std::fs::set_permissions_nofollow` and added a lot more clarifying information. * A test case has been added to verify if `set_permissions_nofollow` is operating correctly. cc @ChrisDenton and @lolbinarycat

@ChrisDenton

…nofollow, r=clarfonthey Added implementation on `set_permissions_nofollow` for all primary platforms For context, this PR is related to the tracking issue for [`std::fs::set_permissions_nofollow`](rust-lang#141607). This PR does a few different things: * Windows support is provided for `std::fs::set_permissions_nofollow`. On Windows, it uses `OpenOptions::open` with the custom flag `FILE_FLAG_OPEN_REPARSE_POINT` enabled and then sets the permissions on the reparse point directly. All other platforms (hermit, motor, solid, uefi, etc.) defer to what `fs::set_permissions` does since symlinks aren't supported on those platforms, so they effectively do the same thing. * The implementation for Unix was modified to use [`fchmodat`](https://linux.die.net/man/2/fchmodat) instead of doing two separate calls (`open` and then `fchmod` via `OpenOptions`). * Because the previous implementations actually used `fchmod` instead of `chmod` underneath the hood (as that's what `File::set_permissions`, which is not to be confused with `fs::set_permissions` as that does use `chmod`, does underneath the hood), it actually had some incorrect documentation about the error returned by `fchmod` on symlinks. Instead of `io::ErrorKind::FilesystemLoop`, it returns `io::ErrorKind::InvalidInput`. You can read the documentation for [`fchmod`](https://pubs.opengroup.org/onlinepubs/009696699/functions/fchmod.html). `fchmodat` does effectively the same thing as the `open` + `fchmod` combo, but it does return a different error, `io::ErrorKind::Unsupported`, that makes more sense. Regardless, I corrected the documentation for `std::fs::set_permissions_nofollow` and added a lot more clarifying information. * A test case has been added to verify if `set_permissions_nofollow` is operating correctly. cc @ChrisDenton and @lolbinarycat

JonathanBrouwer · 2026-06-29T21:00:14Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #158581 (comment)

rust-bors · 2026-06-29T21:00:21Z

This pull request was unapproved.

This PR was contained in a rollup (#158581), which was unapproved.

View changes since this unapproval

clarfonthey · 2026-06-29T21:24:51Z

In case you want to try it out, also, there is documentation on how to run the CI jobs via docker locally: https://rustc-dev-guide.rust-lang.org/tests/ci.html#docker

asder8215 · 2026-06-29T21:52:57Z

Looking at the error, it's coming from me accidentally putting a ; for the value that's supposed to be returned in uefi set_perm...

I think there's a way to do ./x check on a certain platform for compilation issues (in case I don't want to run through the whole CI job + tests). Should I be using --target for this and where do I see the list of available targets to check if the code compiles?

clarfonthey · 2026-06-29T23:32:01Z

There is a list of targets on the rustc book: https://doc.rust-lang.org/nightly/rustc/platform-support.html

You could try cross-referencing with the cfgs in the code to make sure each path is covered, although I mention the docker images since I'm not sure which ones require weird extra host tools or not.

rustbot assigned clarfonthey Jun 20, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 20, 2026

asder8215 force-pushed the windows_set_permissions_nofollow branch from 3411717 to 96bc9a1 Compare June 20, 2026 07:00

This comment has been minimized.

Sign in to view

clarfonthey reviewed Jun 20, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/hermit.rs Outdated

clarfonthey reviewed Jun 20, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/uefi.rs Outdated

clarfonthey reviewed Jun 20, 2026

View reviewed changes

Comment thread library/std/src/fs/tests.rs Outdated

clarfonthey reviewed Jun 20, 2026

View reviewed changes

Comment thread library/std/src/fs/tests.rs

clarfonthey reviewed Jun 20, 2026

View reviewed changes

Comment thread library/std/src/sys/fs/solid.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026

clarfonthey mentioned this pull request Jun 20, 2026

Missing variables/fields give confusing error when name is the same as a built-in attribute like start or path #86290

Open

asder8215 force-pushed the windows_set_permissions_nofollow branch from 96bc9a1 to f9c87ed Compare June 21, 2026 07:25

This comment has been minimized.

Sign in to view

asder8215 requested a review from clarfonthey June 21, 2026 07:27

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 21, 2026

This comment has been minimized.

Sign in to view

asder8215 force-pushed the windows_set_permissions_nofollow branch from f9c87ed to feafe24 Compare June 21, 2026 08:24

This comment has been minimized.

Sign in to view

asder8215 force-pushed the windows_set_permissions_nofollow branch from feafe24 to b286acf Compare June 21, 2026 08:51

This comment has been minimized.

Sign in to view

asder8215 force-pushed the windows_set_permissions_nofollow branch from b286acf to 14df6fa Compare June 21, 2026 19:11

This comment has been minimized.

Sign in to view

asder8215 force-pushed the windows_set_permissions_nofollow branch from 14df6fa to 7029495 Compare June 21, 2026 19:32

rust-bors Bot pushed a commit that referenced this pull request Jun 24, 2026

Auto merge of #158168 - asder8215:windows_set_permissions_nofollow, r…

e01fb44

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 24, 2026

Auto merge of #158168 - asder8215:windows_set_permissions_nofollow, r…

0e4c8bf

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms try-job: dist-various-1

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 24, 2026

Auto merge of #158168 - asder8215:windows_set_permissions_nofollow, r…

a021ffd

…=<try> Added implementation on `set_permissions_nofollow` for all primary platforms try-job: dist-various-1

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2026

JonathanBrouwer mentioned this pull request Jun 29, 2026

Rollup of 14 pull requests #158578

Closed

JonathanBrouwer mentioned this pull request Jun 29, 2026

Rollup of 14 pull requests #158581

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2026

Uh oh!

Uh oh!

Conversation

asder8215 commented Jun 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 20, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

clarfonthey Jun 20, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clarfonthey commented Jun 20, 2026

Uh oh!

rustbot commented Jun 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

JonathanBrouwer commented Jun 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 24, 2026

Uh oh!

clarfonthey commented Jun 29, 2026

Uh oh!

rust-bors Bot commented Jun 29, 2026

Uh oh!

JonathanBrouwer commented Jun 29, 2026

Uh oh!

rust-bors Bot commented Jun 29, 2026

Uh oh!

clarfonthey commented Jun 29, 2026

Uh oh!

asder8215 commented Jun 29, 2026

Uh oh!

clarfonthey commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

asder8215 commented Jun 20, 2026 •

edited by rustbot

Loading

clarfonthey Jun 20, 2026 •

edited by rustbot

Loading