Skip to content

fix: remove ambiguous strings4 into example#2401

Open
leno23 wants to merge 1 commit into
rust-lang:mainfrom
leno23:fix/strings4-useless-conversion
Open

fix: remove ambiguous strings4 into example#2401
leno23 wants to merge 1 commit into
rust-lang:mainfrom
leno23:fix/strings4-useless-conversion

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 20, 2026

Summary

  • remove the ambiguous "nice weather".into() prompt from strings4
  • remove the corresponding solution explanation and #[allow(clippy::useless_conversion)] example
  • keep strings4 focused on values that have one clear String vs &str answer before conversion traits are introduced

Fixes #2190.

Test Plan

  • cargo fmt --check
  • cargo check --manifest-path dev/Cargo.toml --bin strings4_sol
  • cargo clippy --manifest-path dev/Cargo.toml --bin strings4_sol -- -D warnings
  • cargo test --manifest-path dev/Cargo.toml --bin strings4_sol
  • cargo test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

strings4 can pass checks even with a "useless_conversion" warning.

1 participant