Fix regression in implicit casting from integer -> string#304
Merged
Conversation
Modelling AML strings in Rust is tricky; conversion from integers with `String::from_utf8_lossy` keeps trailing null bytes - this is likely fine in C because of how string comparisons would work, but trips up comparison in Rust's `String` (and `CString` cannot have multiple trailing null bytes). This fixes a regression in uACPI's implicit_case_semantics by removing trailing null bytes when doing an integer -> string conversion. It may be that the correct place to fix this holistically is rather in the object comparsion, but this seems like a reasonable step given the current failing case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the recent work with implicit conversions / object comparison introduced a regression in the uACPI
implicit_case_semanticstest.Modelling AML strings in Rust is tricky; conversion from byte slices with
String::from_utf8_lossykeeps trailing null bytes - this is likely fine in C because of how string comparisons would work, but trips up comparison in Rust'sString(andCStringcannot have multiple trailing null bytes).This fixes that by stripping trailing nul bytes entirely when converting integers/buffers to strings. It may be that the correct place to fix this holistically is rather in the object comparsion, but this seems like a reasonable step given the current failing case.