Fix requirements file#75
Open
GilLevi wants to merge 1 commit intosalesforce:mainfrom
Open
Conversation
|
Thanks for the contribution! Before we can merge this, we need @GilLevi to sign the Salesforce.com Contributor License Agreement. |
Author
Contributor
Nah, it seems to work like this all the time |
Author
|
Thanks @bottledmind, hope it will get merged then. |
Contributor
|
The VQA pipeline still requires an en_core_web_sm model. I've created #77 with a hacky way of solving this issue. If you have a better idea, merge it to this PR and inform me to remove mine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The requirements file was not updated, casing a few small issues when running
pip install -e .and trying to run the demo.torchvisionversion is not specified, thus pip tries to install the latest version which is not compatible with torch 1.10.0, addedtorchvision==0.11.1to the requirements file which is the compatible version.lavis/models/img2prompt_models/img2prompt_vqa.pyrequiresspacy, but it was not reflected in the requirements file resulting in an import error when running the demo, addedspacyto the requirement file.spacyrequires a specific version ofpydantic, see issue inspacyrepo here, addedpydantic==1.10.2to the requirements file.Overall small changes, but hopefully it will save a 10 minutes of debugging to the next person:)