Skip to content

Fix: Wrong initialization of variable modality in X-InstructBLIP's generate() within use_cues statement of joint_video_audio#780

Open
globc wants to merge 2 commits intosalesforce:mainfrom
globc:main
Open

Fix: Wrong initialization of variable modality in X-InstructBLIP's generate() within use_cues statement of joint_video_audio#780
globc wants to merge 2 commits intosalesforce:mainfrom
globc:main

Conversation

@globc
Copy link
Copy Markdown

@globc globc commented Jan 7, 2025

This pull request...

  • fixes a wrong initialization of the variable modality within the use_cues statement of X-InstructBLIP's generate() function in joint_video_audio block by moving the modality loop outside.
  • adds a missing continue in X-InstructBLIP's forward() function. Currently modality embeddings are appended twice to input if the conditions are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant