Support multi-line artifact and version#2232
Merged
Merged
Conversation
exoego
commented
Sep 15, 2021
|
|
||
| private def isCommonWord(s: String): Boolean = | ||
| s === "scala" | ||
| s === "scala" || s === "sbt" |
Contributor
Author
There was a problem hiding this comment.
Note) This is added to keep the below test as-is.
sbt-scalafmt vs sbt-pgp.
val original = """val scalafmt = "2.0.1"
|addSbtPlugin("com.jsuereth" % "sbt-pgp" % "2.0.1")
|""".stripMargin
val expected = """val scalafmt = "2.0.7"
|addSbtPlugin("com.jsuereth" % "sbt-pgp" % "2.0.1")
|""".stripMarginI think ignoring sbt is reasonable to avoid wrong match.
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 131 131
Lines 2251 2251
Branches 60 44 -16
=======================================
Hits 1760 1760
Misses 491 491
Continue to review full report at Codecov.
|
Contributor
Author
|
I am going to merge this since the changes is good for maven users. |
Member
Contributor
Author
|
😮 Oh no... |
This was referenced Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2099
Multi-line artifact and its version now will be updated.
This could be helpful specially for Maven users, because dependencies in Maven are often declared like below: