Skip to content

Jdk (7): filled in @param, @tparam, and @return tags that were missed last time#26126

Open
bvenners wants to merge 1 commit into
scala:mainfrom
artimahub:scaladoc-tags-jdk-cleanup
Open

Jdk (7): filled in @param, @tparam, and @return tags that were missed last time#26126
bvenners wants to merge 1 commit into
scala:mainfrom
artimahub:scaladoc-tags-jdk-cleanup

Conversation

@bvenners
Copy link
Copy Markdown
Contributor

As a next step in improving the Scaladoc documentation for the Scala 3 standard library, this PR fills in @param, @tparam, and @return tags for scala.jdk that were missed in the previous batch of PRs. I'm submitting it as a draft PR so to get CI to run on it, to see if it breaks anything, and to start getting feedback. We automated the generation of these changes and are starting to review them. We will review them all before making the PR non-draft. Please let me know if you see anything specific that you think could be improved.

Copy link
Copy Markdown
Contributor

@cheeseng cheeseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions.

Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/javaapi/FunctionConverters.scala
Comment thread library/src/scala/jdk/Accumulator.scala Outdated
@bvenners bvenners force-pushed the scaladoc-tags-jdk-cleanup branch 2 times, most recently from 721a05f to 7e10d9e Compare May 31, 2026 21:45
@bvenners bvenners force-pushed the scaladoc-tags-jdk-cleanup branch from 7e10d9e to df949f3 Compare June 1, 2026 05:35
@bvenners bvenners marked this pull request as ready for review June 1, 2026 05:36
@bvenners bvenners requested a review from a team as a code owner June 1, 2026 05:36
@cheeseng
Copy link
Copy Markdown
Contributor

cheeseng commented Jun 4, 2026

The CI build error seems to be download problem:

Error:  sbt.librarymanagement.ResolveException: Error downloading org.scalacheck:scalacheck_3:1.19.0
Error:    Not found
Error:    Not found
Error:    not found: /home/runner/.ivy2/localorg.scalacheck/scalacheck_3/1.19.0/ivys/ivy.xml
Error:    forbidden: https://repo1.maven.org/maven2/org/scalacheck/scalacheck_3/1.19.0/scalacheck_3-1.19.0.pom

I ran the same command locally and it had no failure, a CI rerun shall fix the problem.

@cheeseng
Copy link
Copy Markdown
Contributor

cheeseng commented Jun 4, 2026

@SethTisue can we try rerunning the related CI build? Thanks. 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants