fix(cli): resolve alias correctly for Vite projects using tsconfig.app.json#11061
Open
Manoj-M-S wants to merge 1 commit into
Open
fix(cli): resolve alias correctly for Vite projects using tsconfig.app.json#11061Manoj-M-S wants to merge 1 commit into
Manoj-M-S wants to merge 1 commit into
Conversation
Contributor
|
@Manoj-M-S is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11044
The
tsconfig-pathslibrary'sloadConfigonly reads the roottsconfig.json. In modern Vite projects scaffolded bycreate-vite, the roottsconfig.jsoncontains onlyreferences(e.g.,{ "references": [{"path": "./tsconfig.app.json"}] }) while the actualpathsconfig lives intsconfig.app.json.Since
loadConfigdoesn't follow references, it returns emptypaths, causing the CLI to treat@/componentsas a literal filesystem path — creating a physical@/directory instead of resolving tosrc/components/.Fix
When
loadConfigreturns a successful result but with nopaths, fall back to manually readingtsconfig.json,tsconfig.web.json, andtsconfig.app.jsonto findcompilerOptions.paths. This covers the standard Vite split-config pattern without changing behavior for projects whereloadConfigalready works.