Skip to content

Update SPIRV-Tools and SPIRV-Headers to latest versions#12028

Open
jhelferty-nv wants to merge 1 commit into
masterfrom
update-spirv-2026-07-09
Open

Update SPIRV-Tools and SPIRV-Headers to latest versions#12028
jhelferty-nv wants to merge 1 commit into
masterfrom
update-spirv-2026-07-09

Conversation

@jhelferty-nv

Copy link
Copy Markdown
Contributor

Motivation

Keep Slang's vendored SPIR-V dependencies current so we pick up the latest SPIR-V grammar, extensions, and validator fixes from upstream KhronosGroup. This is the routine SPIRV submodule bump described in docs/update_spirv.md.

Proposed solution

Advance the external/spirv-tools and external/spirv-headers submodules to their latest upstream commits, keeping spirv-headers pinned to exactly the commit spirv-tools/DEPS expects, and regenerate the checked-in files under external/spirv-tools-generated/ so they match what CI produces.

  • external/spirv-tools: v2022.4-1263-g12f9d942 -> v2022.4-1284-gf877466a (git describe: v2026.3.rc1-1-gf877466a)
  • external/spirv-headers: c63848e -> 29981f6 (matches spirv-tools/DEPS spirv_headers_revision)

build-version.inc was regenerated with --abbrev=8 (via FORCED_BUILD_VERSION_DESCRIPTION) so the git-describe string matches CI's default abbreviation rather than macOS git's.

Change summary

Area Change
external/spirv-tools Submodule bumped to f877466a
external/spirv-headers Submodule bumped to 29981f6 (DEPS-pinned)
external/spirv-tools-generated/build-version.inc Regenerated (new describe string)
external/spirv-tools-generated/core_tables_body.inc Regenerated from the new SPIR-V grammar
external/spirv-tools-generated/core_tables_header.inc Regenerated from the new SPIR-V grammar

No files were added or orphaned; DebugInfo.h, OpenCLDebugInfo100.h, options-pinned.h, and generators.inc were byte-identical after regeneration.

Validation

  • bash extras/check-spirv-generated.sh: all 7 generated files match a fresh build, no orphans, and the spirv-headers commit matches spirv-tools/DEPS.
  • Clean Release rebuild of Slang succeeded.
  • SLANG_RUN_SPIRV_VALIDATION=1 slang-test -use-test-server -server-count 8: 100% passed (7098/7098). GPU-backed Vulkan/D3D/CUDA execution tests were skipped locally (no GPU/Vulkan loader); the static SPIR-V validation across all -target spirv tests plus the CPU/Metal suites ran green. Full GPU coverage is left to CI.

@jhelferty-nv jhelferty-nv requested a review from a team as a code owner July 9, 2026 18:04
@jhelferty-nv jhelferty-nv added the pr: non-breaking PRs without breaking changes label Jul 9, 2026
@jhelferty-nv jhelferty-nv requested review from bmillsNV and removed request for a team July 9, 2026 18:04
@jhelferty-nv jhelferty-nv added the pr: non-breaking PRs without breaking changes label Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • external/spirv-headers is excluded by !external/**
  • external/spirv-tools is excluded by !external/**
  • external/spirv-tools-generated/build-version.inc is excluded by !external/**
  • external/spirv-tools-generated/core_tables_body.inc is excluded by !external/**
  • external/spirv-tools-generated/core_tables_header.inc is excluded by !external/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b02d90f3-31da-476d-86f6-eab89d82e784

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jhelferty-nv jhelferty-nv self-assigned this Jul 9, 2026
@jhelferty-nv jhelferty-nv requested review from jkwak-work and removed request for bmillsNV July 9, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: non-breaking PRs without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant