Update SPIRV-Tools and SPIRV-Headers to latest versions#12028
Update SPIRV-Tools and SPIRV-Headers to latest versions#12028jhelferty-nv wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (5)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
Keep Slang's vendored SPIR-V dependencies current so we pick up the latest SPIR-V grammar, extensions, and validator fixes from upstream KhronosGroup. This is the routine SPIRV submodule bump described in
docs/update_spirv.md.Proposed solution
Advance the
external/spirv-toolsandexternal/spirv-headerssubmodules to their latest upstream commits, keepingspirv-headerspinned to exactly the commitspirv-tools/DEPSexpects, and regenerate the checked-in files underexternal/spirv-tools-generated/so they match what CI produces.external/spirv-tools:v2022.4-1263-g12f9d942->v2022.4-1284-gf877466a(git describe:v2026.3.rc1-1-gf877466a)external/spirv-headers:c63848e->29981f6(matchesspirv-tools/DEPSspirv_headers_revision)build-version.incwas regenerated with--abbrev=8(viaFORCED_BUILD_VERSION_DESCRIPTION) so the git-describe string matches CI's default abbreviation rather than macOS git's.Change summary
external/spirv-toolsf877466aexternal/spirv-headers29981f6(DEPS-pinned)external/spirv-tools-generated/build-version.incexternal/spirv-tools-generated/core_tables_body.incexternal/spirv-tools-generated/core_tables_header.incNo files were added or orphaned;
DebugInfo.h,OpenCLDebugInfo100.h,options-pinned.h, andgenerators.incwere byte-identical after regeneration.Validation
bash extras/check-spirv-generated.sh: all 7 generated files match a fresh build, no orphans, and thespirv-headerscommit matchesspirv-tools/DEPS.SLANG_RUN_SPIRV_VALIDATION=1 slang-test -use-test-server -server-count 8: 100% passed (7098/7098). GPU-backed Vulkan/D3D/CUDA execution tests were skipped locally (no GPU/Vulkan loader); the static SPIR-V validation across all-target spirvtests plus the CPU/Metal suites ran green. Full GPU coverage is left to CI.