Update index.js#1313
Open
karjaneth wants to merge 1 commit intosidorares:masterfrom
Open
Conversation
Adding other constants modules as top-level getters. This will resolve a number of open bugs, including * sidorares#1224 * sidorares#1216 * sidorares#1084 In my own use case, we had been importing `mysql2/lib/constants/errors` in order to support retry-after-deadlock logic, which is now broken since the `exports` are defined in a more limited fashion in `package.json`. This will allow us to simply `import mysql from 'mysql2'` and use `mysql.Errors` for our situation.
Author
|
@sidorares if you are OK with this change and merge it in, would you mind releasing a new version with it as soon as is reasonable? We are just hard-coding error codes until we can go back to importing them from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding other constants modules as top-level getters. This will resolve a number of open bugs, including
In my own use case, we had been importing
mysql2/lib/constants/errorsin order to support retry-after-deadlock logic, which is now broken since theexportsare defined in a more limited fashion inpackage.json. This will allow us to simplyimport mysql from 'mysql2'and usemysql.Errorsfor our situation.