[#6255] Voice Over does not vocalize correctly the hours#6256
Open
pylapp wants to merge 2 commits into
Open
Conversation
Hours were not vocalized properly with Voice Over. For example, a message sent at 11:41, display in the GUI like "11:41", was vocalized "11 41", and not for example in english "11 hours 41 minutes". Defines a dedicated date components formatter with a spelled out unit style to expose only hours and minutes for vocalization. Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
The hours displayed in the paiements pages were not well vocalized. Indeed an time displayed in the GUI "14:06" was vocalzied "14 06" and not in the local hour expression. Thus refactored a bit the things to handle more separatly the displayed value and the accessible value for Voice Over. Signed-off-by: Pierre-Yves Lapersonne <dev@pylapersonne.info>
Contributor
Author
|
Note @sashaweiss-signal This pull request is ready for review :-) |
3 tasks
pylapp
changed the title
pylapp
changed the title
Contributor
|
I'm not sure that for these timestamps we want to read out the exhaustive "hours, minutes" strings, at least in English. I recognize though that in French (and possibly other languages) it's idiomatic to read out the "hours, minutes". Let me check with our design team and localization expert before taking this PR. |
Contributor
Author
|
@sashaweiss-signal Ok! FYI in french we cannot describe an hour (e.g. 8:21 am) to "8 21", but instead "8 heures 21" or "8 heures 21 minutes". Voice Over vocalises the clock hour "8 heures 21". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Time vocalization of messages for Voice Over has been fixed.
Commit ecca307
Hours were not vocalized properly with Voice Over.
For example, a message sent at 11:41, display in the GUI like "11:41",
was vocalized "11 41", and not for example in english "11 hours 41 minutes".
Defines a dedicated date components formatter with a spelled out unit style
to expose only hours and minutes for vocalization.
Vocalization of hours in paiements pages
Commit 1e004e3
The hours displayed in the paiements pages were not well vocalized.
Indeed an time displayed in the GUI "14:06" was vocalzied "14 06" and not
in the local hour expression.
Thus refactored a bit the things to handle more separatly the displayed value
and the accessible value for Voice Over.
Related issue
Closes #6255