bug not awaiting applyCallbacks#194
Open
DaBorsten wants to merge 1 commit into
Open
Conversation
…eholder is larger Previously the callback ran without awaiting, so setRelationTargetCover could finish after the slide was already written, leaving the larger placeholder image in place instead of the replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the applyCallbacks ran without awaiting, so e.g. setRelationTargetCover could finish after the slide was already written, leaving the larger placeholder image in place instead of the replacement.
This issue can be reproduced when setting a bigger image (file size) as a placeholder image in an PowerPoint image placeholder element and then trying to replace it with any other image. The image will not be replaced.
By awaiting applyCallbacks this functions properly now.