refactor: inline single-use parse_bucket_name#158
Open
alukach wants to merge 1 commit into
Open
Conversation
parse_bucket_name was a one-line split_once wrapper with one caller. Inline it at the get_bucket call site. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Claude finished @alukach's task in 32s —— View job ✅ No blocking issues — safe to merge. The inlining is mechanically correct — behavior is identical to the removed helper. One minor observation:
|
|
🚀 Latest commit deployed to https://source-data-proxy-pr-158.source-coop.workers.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
parse_bucket_namewas a one-linesplit_oncewrapper called from a single place (get_bucket). Inline it.Why
A named helper that wraps a single stdlib call and has one caller is indirection without payoff. The call site is just as clear with
split_onceinline.Verification
Full pre-push suite (fmt, clippy wasm32, wasm check, tests) green.
Found via ponytail over-engineering audit.
🤖 Generated with Claude Code