-
-
Notifications
You must be signed in to change notification settings - Fork 188
feat!: migrate nodejs to custom resources #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
61c2c8d
chore(deps): update actions to v6 (#303)
renovate[bot] 534757b
feat!: migrate nodejs to resources
damacus 6482253
fix: satisfy markdown and cookstyle lint
damacus 07eb78a
fix: skip unavailable nodejs dnf module
damacus f80c12d
fix: stabilize nodejs integration suites
damacus 580c949
fix: align nodejs workflow permissions
damacus 967ad7e
fix: install git in nodejs test cookbook
damacus 32a5dd3
fix: handle python for nodejs source builds
damacus b24c678
fix: guard source python symlink portably
damacus 8da768a
fix: move nodejs defaults into resources
damacus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,6 @@ | ||
| require: | ||
| - cookstyle | ||
|
|
||
| AllCops: | ||
| Exclude: | ||
| - 'vendor/**/*' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| source 'https://supermarket.chef.io' | ||
|
|
||
| metadata | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| # Contributing | ||
|
|
||
| Please refer to | ||
| [https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/CONTRIBUTING.MD](https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/CONTRIBUTING.MD) | ||
| [<https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/CONTRIBUTING.MD](https://github.com/chef-cookbooks/community_cookbook_documentation/blob/main/CONTRIBUTING.MD>) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Limitations | ||
|
|
||
| This cookbook defaults to Node.js 24 LTS, using Node.js v24.15.0 checksums from the official `SHASUMS256.txt` published for `latest-v24.x` on 2026-04-16. | ||
|
|
||
| Sources checked on 2026-04-29: | ||
|
|
||
| * Node.js release schedule: <https://github.com/nodejs/Release/blob/main/schedule.json> | ||
| * Node.js latest v24 artifacts: <https://nodejs.org/dist/latest-v24.x/> | ||
| * Node.js v24 checksums: <https://nodejs.org/dist/latest-v24.x/SHASUMS256.txt> | ||
| * NodeSource distributions page: <https://nodesource.com/products/distributions> | ||
| * NodeSource distributions repository: <https://github.com/nodesource/distributions> | ||
|
|
||
| ## Package Availability | ||
|
|
||
| ### APT (Debian/Ubuntu) | ||
|
|
||
| NodeSource documents Node 24 packages for: | ||
|
|
||
| * Ubuntu 20.04, 22.04, 24.04: `amd64`, `armhf`, `arm64` | ||
| * Debian 10, 11, 12: `amd64`, `armhf`, `arm64` | ||
|
|
||
| The cookbook only declares currently supported, non-EOL Debian/Ubuntu platforms in `metadata.rb`: Debian 12 or later and Ubuntu 22.04 or later. NodeSource packages use the `nodistro` repository distribution. | ||
|
|
||
| ### DNF/YUM (RHEL family) | ||
|
|
||
| NodeSource documents RPM packages for RHEL 8/9, Fedora 29+, and Amazon Linux 2023 on `x86_64` and `arm64`. The repository URL pattern used by this cookbook is: | ||
|
|
||
| ```text | ||
| <https://rpm.nodesource.com/pub_<major>>.x/nodistro/nodejs/$basearch | ||
| ``` | ||
|
|
||
| The cookbook declares AlmaLinux, Amazon Linux 2023, CentOS Stream, Fedora, Oracle Linux, Red Hat, and Rocky Linux where current test images are available. | ||
|
|
||
| ### Zypper (SUSE) | ||
|
|
||
| NodeSource does not publish SUSE repository rows in the current distributions documentation. This migration does not declare SUSE/openSUSE support in `metadata.rb`. | ||
|
|
||
| ### Windows and macOS | ||
|
|
||
| Windows support is limited to `nodejs_install` with `install_method 'chocolatey'`. macOS support is limited to package installation through the platform package provider where available. Dokken coverage is Linux-only. | ||
|
|
||
| ## Architecture Limitations | ||
|
|
||
| Official Node.js v24.15.0 source and binary checksums pinned by this cookbook: | ||
|
|
||
| | Artifact | SHA256 | | ||
| | ---------------------------------- | ------------------------------------------------------------------ | | ||
| | `node-v24.15.0.tar.gz` | `729de494dd2872e5a3a6c32a1cd156a5413d4aca2772b2d873ee86bb5531bcd9` | | ||
| | `node-v24.15.0-linux-x64.tar.gz` | `44836872d9aec49f1e6b52a9a922872db9a2b02d235a616a5681b6a85fec8d89` | | ||
| | `node-v24.15.0-linux-arm64.tar.gz` | `73afc234d558c24919875f51c2d1ea002a2ada4ea6f83601a383869fefa64eed` | | ||
|
|
||
| The `nodejs_install` binary action currently models Linux `x64` and `arm64` checksums. Other official Node.js artifacts can be installed by passing `binary_url` and the matching checksum. | ||
|
|
||
| ## Source/Compiled Installation | ||
|
|
||
| ### Build Dependencies | ||
|
|
||
| | Platform Family | Packages | | ||
| | ------------------ | ---------------------------------------------------- | | ||
| | Debian | `build-essential`, `libssl-dev`, `python3` | | ||
| | RHEL/Fedora/Amazon | `build-essential`, `openssl-devel`, `python3`, `tar` | | ||
| | Other | `build-essential`, `python3` | | ||
|
|
||
| Source builds are much slower than package or binary installs and are not used as the default Kitchen smoke path. | ||
|
|
||
| ## Known Issues | ||
|
|
||
| * Node.js 20 reaches end-of-life on 2026-04-30, so this migration does not keep old Node 20 defaults. | ||
| * NodeSource repository docs currently show some LTS/current labels that lag the official Node.js release schedule. The cookbook version defaults follow the official Node.js release schedule and official Node.js checksum artifacts. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.