Fix exchange rates: migrate from frankfurter.app to frankfurter.dev#515
Open
stefantaubert wants to merge 1 commit into
Open
Fix exchange rates: migrate from frankfurter.app to frankfurter.dev#515stefantaubert wants to merge 1 commit into
stefantaubert wants to merge 1 commit into
Conversation
BastiOfBerlin
pushed a commit
to BastiOfBerlin/spliit
that referenced
this pull request
Jun 11, 2026
Port several improvements from upstream spliit-app/spliit: - Exchange rates: migrate from api.frankfurter.app to api.frankfurter.dev/v1, fixing broken foreign-currency conversion (upstream spliit-app#515 / bugs spliit-app#513, spliit-app#514). - Selectors: wrap category and currency lists in cmdk's CommandList so keyboard (arrow-key) navigation works again (upstream spliit-app#491). - Group sharing: render a scannable QR code of the invite link in the share popover via qrcode.react (upstream spliit-app#500). - Currencies: add COP, VND, MKD, and MYR to the supported list and regenerate the per-locale currency data (upstream spliit-app#486, spliit-app#507, spliit-app#516, spliit-app#521). - React Compiler: enable Next.js 16's stable reactCompiler for automatic memoization, adding the babel-plugin-react-compiler dev dependency (upstream spliit-app#503). - Docker build: parse package.json name/version with POSIX tools instead of `node -p`, so the image can be built on hosts without Node.js (upstream spliit-app#219). - Docs: document the Docker Compose workflow and stack in the README (upstream spliit-app#505).
BastiOfBerlin
pushed a commit
to BastiOfBerlin/spliit
that referenced
this pull request
Jun 11, 2026
Port several improvements from upstream spliit-app/spliit: - Exchange rates: migrate from api.frankfurter.app to api.frankfurter.dev/v1, fixing broken foreign-currency conversion (upstream spliit-app#515 / bugs spliit-app#513, spliit-app#514). - Selectors: wrap category and currency lists in cmdk's CommandList so keyboard (arrow-key) navigation works again (upstream spliit-app#491). - Group sharing: render a scannable QR code of the invite link in the share popover via qrcode.react (upstream spliit-app#500). - Currencies: add COP, VND, MKD, and MYR to the supported list and regenerate the per-locale currency data (upstream spliit-app#486, spliit-app#507, spliit-app#516, spliit-app#521). - React Compiler: enable Next.js 16's stable reactCompiler for automatic memoization, adding the babel-plugin-react-compiler dev dependency (upstream spliit-app#503). - Docker build: parse package.json name/version with POSIX tools instead of `node -p`, so the image can be built on hosts without Node.js (upstream spliit-app#219). - Docs: document the Docker Compose workflow and stack in the README (upstream spliit-app#505).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #514
The Frankfurter API has moved from
api.frankfurter.apptoapi.frankfurter.dev.The old domain returns a 301 redirect without CORS headers, which causes the browser
to block exchange rate requests.
Problem
https://api.frankfurter.app/2026-04-05?base=CNY→ 301 redirect toapi.frankfurter.devAccess-Control-Allow-OriginheaderFix
Replace
api.frankfurter.appwithapi.frankfurter.dev/v1in the exchange rate client.Note:
frankfurter.devalso offers a v2 API, but it has a different response schema.This PR intentionally uses
/v1/to maintain compatibility without requiringadditional changes to the response parsing logic.
Test plan