Skip to content

add hironx_calibration#251

Merged
130s merged 1 commit into
start-jsk:hydro-develfrom
k-okada:hironx_calibration
Sep 29, 2014
Merged

add hironx_calibration#251
130s merged 1 commit into
start-jsk:hydro-develfrom
k-okada:hironx_calibration

Conversation

@k-okada
Copy link
Copy Markdown
Member

@k-okada k-okada commented Sep 24, 2014

add hironx calibration package, this depends on https://github.com/ros-perception/calibration (need to merge ros-perception/calibration#31)

Before calibrate (with no offset between head and camera)
hiro_before_calibrate

and after calibrate. It is not accurent enough but it may be due to using xition(kermine)...
hiro_after_calibrate

@k-okada
Copy link
Copy Markdown
Member Author

k-okada commented Sep 24, 2014

@k-okada
Copy link
Copy Markdown
Member Author

k-okada commented Sep 24, 2014

Image to shows how to put xtion on head and put calibration board
hiro_xtion_calibborad

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add run_depend on calibration_setup_helper here based on ros-perception/calibration#31?

@130s
Copy link
Copy Markdown
Contributor

130s commented Sep 26, 2014

+1!

travis already passed before ros-perception/calibration#31 gets merged maybe because it's only supposed to be run_depended. If that's correct then maybe we can merge this now.

@k-okada
Copy link
Copy Markdown
Member Author

k-okada commented Sep 27, 2014

you can merge this,

we need calibration_setup_helper to create/generate this package, not to
run this package.

On Sat, Sep 27, 2014 at 1:11 AM, Isaac I.Y. Saito notifications@github.com
wrote:

+1!

travis already passed before ros-perception/calibration#31
ros-perception/calibration#31 gets merged maybe
because it's only supposed to be run_depended. If that's correct then
maybe we can merge this now.


Reply to this email directly or view it on GitHub
#251 (comment)
.

@garaemon
Copy link
Copy Markdown
Member

Please use pr2_navigation_filter to filter out the points belong to robot
itself
PR2/pr2_navigation#12 (comment)

After hand-eye calibration, it should work

2014年9月27日土曜日、Kei Okadanotifications@github.comさんは書きました:

you can merge this,

we need calibration_setup_helper to create/generate this package, not to
run this package.

On Sat, Sep 27, 2014 at 1:11 AM, Isaac I.Y. Saito <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

+1!

travis already passed before ros-perception/calibration#31
ros-perception/calibration#31 gets merged
maybe
because it's only supposed to be run_depended. If that's correct then
maybe we can merge this now.


Reply to this email directly or view it on GitHub
<
https://github.com/start-jsk/rtmros_hironx/pull/251#issuecomment-56983068>

.


Reply to this email directly or view it on GitHub
#251 (comment)
.

from iPhone

@130s
Copy link
Copy Markdown
Contributor

130s commented Sep 29, 2014

@k-okada we need calibration_setup_helper to create/generate this package, not to run this package.

Got it.

@garaemon Please use pr2_navigation_filter to filter out the points belong to robot itself

Can you point to an example package that does this if anything?
And, that will be taken care of in another PReq. Merging this.

130s added a commit that referenced this pull request Sep 29, 2014
@130s 130s merged commit fe7ce29 into start-jsk:hydro-devel Sep 29, 2014
@garaemon
Copy link
Copy Markdown
Member

You can get sample codes around here

@130s
Copy link
Copy Markdown
Contributor

130s commented Sep 29, 2014

Pictures from this ticket are added to the tutorial. http://wiki.ros.org/rtmros_nextage/Tutorials/CalibrateKinect

@130s
Copy link
Copy Markdown
Contributor

130s commented Sep 29, 2014

Thanks!

You can get sample codes around here

@130s 130s mentioned this pull request Oct 2, 2014
@k-okada k-okada deleted the hironx_calibration branch October 20, 2014 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants