Skip to content

fix: launch VS Code tunnel safely and modernize Node runtime#73

Merged
sourishkrout merged 1 commit into
mainfrom
trude/fix-windows-vscode-spawn
Jun 23, 2026
Merged

fix: launch VS Code tunnel safely and modernize Node runtime#73
sourishkrout merged 1 commit into
mainfrom
trude/fix-windows-vscode-spawn

Conversation

@sourishkrout

@sourishkrout sourishkrout commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

  • launch the Windows VS Code tunnel through code-tunnel.exe instead of the code.cmd shim
  • make macOS VS Code CLI resolution tolerate flattened @vscode/test-electron app bundles
  • normalize Unix executable permissions before spawning the VS Code CLI
  • remove temporary tunnel probe/debug output and inherit stdio for tunnel commands
  • sanitize custom machine names before passing them to VS Code
  • move the action/runtime tooling to Node 24
  • update CI actions and Node version, plus TypeScript/tsconfig/node typings for the Node 24 baseline
  • update tests and rebuild the bundled dist/index.js

Why

GitHub-hosted runners execute JavaScript actions on modern Node runtimes. The previous Windows path failed first on raw .cmd spawning, then the VS Code code.cmd shim failed on hosted Windows with The system cannot find the path specified.

Using code-tunnel.exe directly avoids the shim entirely on Windows. While here, the action metadata and CI are moved off stale Node 16/20 assumptions so the repo tests the runtime GitHub is moving Actions toward.

A local Darwin smoke also exposed that the VS Code test download can return a .app/.../Electron path while the extracted files are flattened under Contents/..., with CLI files lacking executable bits. The action now handles that before spawning.

Verification

  • yarn test on Node 24
  • yarn run build on Node 24
  • INPUT_TIMEOUT=5000 INPUT_MACHINENAME=local-darwin GITHUB_RUN_ID=local-darwin node dist/index.js on Darwin/Node 24
  • pre-commit hook: yarn test:lint
  • pre-commit hook: yarn run build

@sourishkrout sourishkrout force-pushed the trude/fix-windows-vscode-spawn branch 2 times, most recently from 5a2c40d to 9f76cf4 Compare June 22, 2026 22:51
@sourishkrout sourishkrout changed the title fix: launch VS Code command shim safely on Windows fix: launch VS Code tunnel safely and modernize Node runtime Jun 22, 2026
@sourishkrout sourishkrout force-pushed the trude/fix-windows-vscode-spawn branch from 9f76cf4 to 8e50c5c Compare June 22, 2026 23:33
@sourishkrout sourishkrout force-pushed the trude/fix-windows-vscode-spawn branch from 8e50c5c to 191aeab Compare June 23, 2026 00:03
@sourishkrout sourishkrout merged commit 8477f2f into main Jun 23, 2026
6 checks passed
@sourishkrout sourishkrout deleted the trude/fix-windows-vscode-spawn branch June 23, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant