fix: launch VS Code tunnel safely and modernize Node runtime#73
Merged
Conversation
5a2c40d to
9f76cf4
Compare
9f76cf4 to
8e50c5c
Compare
8e50c5c to
191aeab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-tunnel.exeinstead of thecode.cmdshim@vscode/test-electronapp bundlesdist/index.jsWhy
GitHub-hosted runners execute JavaScript actions on modern Node runtimes. The previous Windows path failed first on raw
.cmdspawning, then the VS Codecode.cmdshim failed on hosted Windows withThe system cannot find the path specified.Using
code-tunnel.exedirectly avoids the shim entirely on Windows. While here, the action metadata and CI are moved off stale Node 16/20 assumptions so the repo tests the runtime GitHub is moving Actions toward.A local Darwin smoke also exposed that the VS Code test download can return a
.app/.../Electronpath while the extracted files are flattened underContents/..., with CLI files lacking executable bits. The action now handles that before spawning.Verification
yarn teston Node 24yarn run buildon Node 24INPUT_TIMEOUT=5000 INPUT_MACHINENAME=local-darwin GITHUB_RUN_ID=local-darwin node dist/index.json Darwin/Node 24yarn test:lintyarn run build