-
Notifications
You must be signed in to change notification settings - Fork 12
enable sending to federated address #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c7e88e8
enable sending to federated address
leofelix077 05eef5f
adjust clearing search state and debounce
leofelix077 679d22f
Merge branch 'main' into lf-enable-send-federated-address
leofelix077 01831d7
carry forward federated address on contacts and review
leofelix077 0d750e3
Merge branch 'lf-enable-send-federated-address' of github.com:stellar…
leofelix077 3856256
add tests to CI
leofelix077 43a3309
update shard-total
leofelix077 6a9b311
harden federated address validation and e2e flow for usdc and xlm
leofelix077 411ae5a
Merge branch 'main' into lf-enable-send-federated-address
leofelix077 24629d4
add loading state for search and parity validation with extension
leofelix077 6210d3d
Merge branch 'lf-enable-send-federated-address' of github.com:stellar…
leofelix077 a114efb
Merge branch 'main' into lf-enable-send-federated-address
leofelix077 babf8b1
truncate federated address and memo type inference
leofelix077 90cb793
remove extra text on required by recipient
leofelix077 d7f5778
fix e2e test
leofelix077 6ec12d7
fix e2e test
leofelix077 716c0e2
fix e2e test
leofelix077 432f10e
harden federated address ascii validation
leofelix077 9dcf54a
fix federation address validation regex
leofelix077 40178cd
Merge remote-tracking branch 'origin/main' into lf-enable-send-federa…
leofelix077 34dd9cf
update address type distinction and memo validation
leofelix077 7918bc3
Remove unused ContactType enum and type property
leofelix077 926531a
Merge main into lf-enable-send-federated-address
leofelix077 efdb30c
merge main into branch and fix conflicts
leofelix077 0741bec
Merge branch 'main' into lf-enable-send-federated-address
leofelix077 a4281a0
Merge branch 'lf-enable-send-federated-address' of github.com:stellar…
leofelix077 2415b0f
fix merge conflicts
leofelix077 ac64f71
revert merge conflicts changes
leofelix077 75fa6b5
Merge branch 'main' into lf-enable-send-federated-address
leofelix077 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SendSearchContacts tests’
useSendRecipientStoremock only addsclearSearchState, but the component now also readsisSearching,isValidDestination, andisDestinationFundedfrom the store. The mock should provide realistic defaults for these fields to avoid the component taking different render paths in tests vs production. Additionally, the module mock forhelpers/stellarshould exportisFederationAddressnow that the component imports/uses it; otherwise any test that triggershandleContactPresswill throw. Finally, since search is now debounced viasetTimeout, assertions thatsearchAddresswas called may need fake timers / advancing timers to avoid flakiness.