-
Notifications
You must be signed in to change notification settings - Fork 33
(closes #3243) Unify and document nemo scritps #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sergisiso
wants to merge
46
commits into
master
Choose a base branch
from
single_nemo_script
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 36 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
6000775
Start updating nemo README
sergisiso ac6df07
Merge branch 'unresolved_as_calls' into single_nemo_script
sergisiso 85e7249
Merge branch 'unresolved_as_calls' into single_nemo_script
sergisiso 48f0a8c
Update NEMO readmes
sergisiso a9618c0
Add initial version of the unified insert_loop_parallelism.py script
sergisiso 525e111
Fixes to NEMO insert_loop_parallelism.py
sergisiso 8cc4582
Merge branch 'unresolved_as_calls' into single_nemo_script
sergisiso d037cc0
Remove NEMO omp_cpu_trans.py
sergisiso 394f8f3
Replace NEMO omp_gpu_trans.py
sergisiso 6fd4de1
Fix some issues with new NEMO script
sergisiso 6a89eb9
Attempt to fix issues with NEMO OpenACC
sergisiso 2252a48
Add allow_strings validation option to ACCParallel
sergisiso eeb2b10
Merge remote-tracking branch 'origin/3188_tighten_privatisation_valid…
sergisiso 73fb247
Exlcude icb from NEMO insert_loop_parallelism and skip failing async
sergisiso 6607aec
Reorder NEMO readme and add section about identifying problems
sergisiso 1e57470
Update NEMO README
sergisiso aea4c0e
Update NEMO script to only exclude files with offloading issues in NE…
sergisiso 782a163
Replace acc_loop_trans in NEMOv4 test
sergisiso ca2c06e
Remove unneeded NEMO flag
sergisiso 1e52822
Fix wrong path in NEMO integration test
sergisiso d767908
Bring unresolved_as_calls changes
sergisiso 0a7c24f
Small change of location of NEMO utils.py conditional
sergisiso 46980be
Bring unresolved_as_calls changes
sergisiso 0b6366d
Merge branch 'unresolved_as_calls' into single_nemo_script
sergisiso b29c66f
Merge branch 'unresolved_as_calls' into single_nemo_script
sergisiso 98f5dca
Fix issues with CI and integration tests
sergisiso 71270ce
In ECMWF NEMOv4 include mpif.h during cpp
sergisiso 0b80c98
Test ACCParallelTrans allow_strings
sergisiso 9125e6a
Add no-vectorize and no-fma to the NEMOv5 gcc reproducible checks
sergisiso 17eb6c5
Reintroduce NEMOv4 compile-time MPI include
sergisiso bab0524
Clean up NEMO README and scritps
sergisiso 2c1f468
Uncomment integration test for NEMO ORCA2 async
sergisiso 3ae2c17
Update NEMOv4 with mpi include flag
sergisiso 882c146
Try removing exclusions from NEMO tests
sergisiso dfb6b0a
Make NEMOv4 dynspg_ts exclusion exclusive to the ArrayAssignment2Loop…
sergisiso 628a1cc
Merge remote-tracking branch 'origin/master' into single_nemo_script
sergisiso 4f92604
#3244 Fix typos and add TODO
sergisiso 1a177d2
#2144 Try to improve hybrid performance
sergisiso 32057f1
#3244 Revert last changes and don't collapse CPU loops
sergisiso f0f5413
Bring to master
sergisiso 1fc199e
Merge remote-tracking branch 'origin/master' into single_nemo_script
sergisiso d1dba5a
Merge branch 'master' into single_nemo_script
sergisiso cccb9f6
Bring to master
sergisiso 55d44fc
Remove old statements brought by the last merge
sergisiso 355a801
Clean up previous merge conflicts
sergisiso 69ad36f
Revert some OpenACC changes
sergisiso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,8 +43,8 @@ transform: omp_levels | |
|
|
||
| omp_levels: | ||
| ${PSYCLONE} -s ./omp_levels_trans.py ../code/traldf_iso.F90 | ||
| ${PSYCLONE} -s ../scripts/omp_cpu_trans.py ../code/traldf_iso.F90 | ||
| ${PSYCLONE} -s ../scripts/omp_gpu_trans.py ../code/traldf_iso.F90 | ||
| PARALLEL_DIRECTICVES="omp_threading" ${PSYCLONE} -s ../scripts/insert_loop_parallelism.py ../code/traldf_iso.F90 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also should be
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
| PARALLEL_DIRECTICVES="omp_offloading" ${PSYCLONE} -s ../scripts/insert_loop_parallelism.py ../code/traldf_iso.F90 | ||
|
|
||
|
|
||
| compile: transform | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
PARLLEL_DIRECTIVESI think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups, fixed