feat(examples,metrics,kube-state-metrics): extend configmap for 'KafkaConnect', 'KafkaConnector' and 'KafkaMirrorMaker2'#11354
Conversation
|
Thanks for the review. I simply applied your suggestions 🚀 |
im-konge
left a comment
im-konge
left a comment
There was a problem hiding this comment.
So I tried the changes locally (I played with the Ready and NotReady states), everything seems to work fine:
https://gist.github.com/im-konge/3a6793a7f10bb543b3f1dc3044504195
so LGTM, thanks for the PR @sebastiangaiser !
|
@strimzi/maintainers could you please have a look on this? It's opened for quite a long time. Thanks |
katheris
left a comment
katheris
left a comment
There was a problem hiding this comment.
If my understanding is correct the metric mapping for KafkaMirrorMaker2 is incorrect since the field for the auto restart is different to KafkaConnector.
|
Good catch, thanks 👍🏻 |
|
Is the failed test |
|
@sebastiangaiser I merged big PR rewriting a lot of things in our STs. Did you do rebase? Also, did you have any conflicts or something? |
|
Actually, #11198 broke the main because of the PR wasn't rebased IMHO before merge. I'm gonna open a new PR fixing the issue on main. Sorry for the issues. |
|
@sebastiangaiser I opened fix for the build #11523 |
|
@sebastiangaiser PR is merged, could you please rebase this PR? Thanks |
ppatierno
left a comment
ppatierno
left a comment
There was a problem hiding this comment.
LGTM. @sebastiangaiser we just need it to be rebased to have the build passing. Thanks!
|
Hey @sebastiangaiser, could you please rebase this PR, so we can merge it eventually? The rebase should fix the error you see in the build pipeline, as I mentioned in previous comment. Thanks! |
This is part of implementing https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
…aConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' In order to implement https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md the configmap is extended for 'KafkaConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' resources. Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
…afkaConnector' and 'KafkaMirrorMaker2' Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com> Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com>
|
Rebased, sorry for the delay. Didn't had a laptop with me over the last week. |
No issues, sorry for two pings 🙂 we can merge this once the build pipeline is green. Thanks a lot once more! |
|
Thanks for the PR @sebastiangaiser ! |
…aConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' (strimzi#11354) Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com> Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com>
…aConnect', 'KafkaConnector' and 'KafkaMirrorMaker2' (strimzi#11354) Signed-off-by: Sebastian Gaiser <sebastiangaiser@users.noreply.github.com> Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com>
5 participants
Part of #10276
Type of change
Select the type of your PR
Description
Please check the commit messages
Checklist
Please go through this checklist and make sure all applicable tasks have been done