Allow configuring additional options when restarting connectors by rlanhellas · Pull Request #11797 · strimzi/strimzi-kafka-operator

rlanhellas · 2025-09-01T13:02:28Z

Type of change

Enhancement

Description

Fixes #11762 #11484
This PR implements this proposal: https://github.com/strimzi/proposals/blob/main/111-add-restart-parameters-to-kafka-connectors.md.

Checklist

Write tests
Make sure all tests pass
Update documentation
Check RBAC rights for Kubernetes / OpenShift roles
Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
Reference relevant issue(s) and close them after merging
Update CHANGELOG.md
Supply screenshots for visual changes, such as Grafana dashboards

ppatierno · 2025-09-01T14:30:45Z

@rlanhellas there are some checkstyle failures within the Azure pipeline.

ppatierno

Thanks @rlanhellas! I was wondering we need some tests about the new annotation values to check that also patterns are valid.

ppatierno · 2025-09-01T14:32:50Z

+            if (!restartAnnotationIsValid(resource)) {
+                String message = "Invalid annotation format";
+                LOGGER.warnCr(reconciliation, message);
+                conditions.add(StatusUtils.buildWarningCondition("RestartConnector", message));


I think we can just put the string in the log and condition even if it's the same. This is anyway what the compiler is going to do. Not sure how much value the message variable can bring here, considering that the two lines using the message are close each other and not spread across the codebase.

ppatierno · 2025-09-01T14:34:47Z

+    /**
+     * Pattern for validation of MirrorMaker2 restart connector annotation value.
+     * */
+    public static final Pattern ANNO_STRIMZI_IO_RESTART_CONNECTOR_ARGS_PATTERN = Pattern


if it's just for MirrorMaker 2 maybe we should state it in the name (even just adding MM2 somewhere would be ok for me).

done, just added MM2

rlanhellas · 2025-09-01T14:37:49Z

Thanks @rlanhellas! I was wondering we need some tests about the new annotation values to check that also patterns are valid.

agree, I'm writing tests to this, will update this PR soon.

rlanhellas · 2025-09-01T14:40:24Z

@rlanhellas there are some checkstyle failures within the Azure pipeline.

fixed

scholzj

Thanks for the PR. I left some nits. You should also:

fix the title of the PR
Add it to the CHANGELOG file
Add it to the docs

scholzj · 2025-09-01T19:04:16Z

+    /**
+     * Pattern for validation of restart connector annotation value.
+     * */
+    public static final Pattern ANNO_STRIMZI_IO_RESTART_ARGS_PATTERN = Pattern.compile("^includeTasks," +
+            "onlyFailed$|^onlyFailed,includeTasks$|^includeTasks$|^onlyFailed$|^true$");
+
+    /**
+     * Pattern for validation of MirrorMaker2 restart connector annotation value.
+     * */
+    public static final Pattern ANNO_STRIMZI_IO_RESTART_CONNECTOR_MM2_ARGS_PATTERN = Pattern
+            .compile("^([a-zA-Z0-9-_]+):includeTasks,onlyFailed$|^([a-zA-Z0-9-_]+):onlyFailed,includeTasks$" +
+                    "|^([a-zA-Z0-9-_]+):includeTasks$|^([a-zA-Z0-9-_]+):onlyFailed$|^([a-zA-Z0-9-_]+)$");
+
+    /**
+     * This optional argument can be used to include tasks in the restart connector operation.
+     * */
+    public static final String ANNO_STRIMZI_IO_RESTART_INCLUDE_TASKS_ARG = "includeTasks";
+
+    /**
+     * This optional argument can be used to restart connector only failed tasks.
+     * */
+    public static final String ANNO_STRIMZI_IO_RESTART_ONLY_FAILED_ARG = "onlyFailed";
+


As these are not really annotations, can we keep these internally in the corresponding classes?

scholzj · 2025-09-01T19:05:12Z

+     */
+    @SuppressWarnings({ "rawtypes" })
+    @Override
+    protected boolean restartAnnotationHasOnlyFailedTasksArg(CustomResource resource) {


These methods can probably use the HasMetadata interface instead of CustomResource? The same applies also to the Connect methods.

scholzj · 2025-09-01T19:05:43Z

+            if (!restartAnnotationIsValid(resource)) {
+                LOGGER.warnCr(reconciliation, "Invalid annotation format");
+                conditions.add(StatusUtils.buildWarningCondition("RestartConnector", "Invalid annotation format"));
+                return Future.succeededFuture(conditions);
+            }
+            boolean restartIncludeTasks = restartAnnotationHasIncludeTasksArg(resource);
+            boolean restartOnlyFailedTasks = restartAnnotationHasOnlyFailedTasksArg(resource);
+            LOGGER.infoCr(reconciliation, "Restarting connector {}", connectorName);
+            return VertxUtil.completableFutureToVertxFuture(apiClient.restart(host, port, connectorName, restartIncludeTasks, restartOnlyFailedTasks))


You should probably add some spacing (empty lines) for better readability.

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

codecov-commenter · 2025-09-09T01:06:04Z

Codecov Report

❌ Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.55%. Comparing base (489652d) to head (1f3c544).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
...or/assembly/KafkaMirrorMaker2AssemblyOperator.java	76.47%	2 Missing and 2 partials ⚠️
...perator/assembly/KafkaConnectAssemblyOperator.java	90.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11797      +/-   ##
============================================
+ Coverage     67.51%   67.55%   +0.03%     
- Complexity     7080     7101      +21     
============================================
  Files           574      574              
  Lines         28134    28181      +47     
  Branches       3187     3201      +14     
============================================
+ Hits          18995    19037      +42     
+ Misses         7824     7820       -4     
- Partials       1315     1324       +9

Files with missing lines	Coverage Δ
...ter/operator/assembly/AbstractConnectOperator.java	`78.53% <100.00%> (+0.30%)`	⬆️
...perator/assembly/KafkaConnectAssemblyOperator.java	`88.02% <90.47%> (+0.12%)`	⬆️
...or/assembly/KafkaMirrorMaker2AssemblyOperator.java	`84.78% <76.47%> (+4.42%)`	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

rlanhellas · 2025-09-09T15:43:28Z

everything is done @scholzj, @ppatierno , if you can take a look again

scholzj · 2025-09-09T23:40:19Z

+    private static final Pattern STRIMZI_IO_RESTART_ARGS_PATTERN = Pattern.compile("^includeTasks," +
+            "onlyFailed$|^onlyFailed,includeTasks$|^includeTasks$|^onlyFailed$|^true$");


This seems pretty hacky. Maybe you can split it by , into a list and check the values or something?

I changed the validation to if-else statement and removed the regex pattern

scholzj · 2025-09-09T23:44:06Z

+    abstract boolean restartAnnotationIsValid(CustomResource resource);
+
+    /**
+     * Checks whether the provided resource instance (a KafkaConnector or KafkaMirrorMaker2) has argument includeTasks in restart annotation.
+     *
+     * @param resource          Resource instance to check
+     *
+     * @return True if the provided resource has argument includeTasks in restart annotation. False otherwise.
+     */
+    @SuppressWarnings({ "rawtypes" })
+    abstract boolean restartAnnotationHasIncludeTasksArg(CustomResource resource);
+
+    /**
+     * Checks whether the provided resource instance (a KafkaConnector or KafkaMirrorMaker2) has argument onlyFailedTasks in restart annotation.
+     *
+     * @param resource          Resource instance to check
+     *
+     * @return True if the provided resource has argument onlyFailedTasks in restart annotation. False otherwise.
+     */
+    @SuppressWarnings({ "rawtypes" })
+    abstract boolean restartAnnotationHasOnlyFailedTasksArg(HasMetadata resource);


Did you check here and with the implementations if you can use HasMetadata instead of CustomResource?

I forgot to change the implementations, just did it

scholzj · 2025-09-09T23:46:01Z

+    private static final Pattern STRIMZI_IO_RESTART_CONNECTOR_MM2_ARGS_PATTERN = Pattern
+            .compile("^([a-zA-Z0-9-_]+):includeTasks,onlyFailed$|^([a-zA-Z0-9-_]+):onlyFailed,includeTasks$" +
+                    "|^([a-zA-Z0-9-_]+):includeTasks$|^([a-zA-Z0-9-_]+):onlyFailed$|^([a-zA-Z0-9-_]+)$");


Same as in the other expression. Maybe we can try to simplify it a bit? Parse our the comnand part using the Regexp and than split it rather than including all various combiantions? This does not scale very well.

In addition, whatever the way to parse it is, it might be good to have some unit tests for how it parses the various annotations (both here as well as for connect). With some valid and invalid values etc.

I changed the validation to if-else statement and removed the regex pattern

Btw, regarding testing invalid args, you can check the tests, I added a test to invalid args

I see. It is probably good to test it with invalid value once in the way you have it.

But why don't you just test the methods for validating the annotations / checking the presence of the arguments? You can easily test them with 10 different valid and invalid values without the need for any mocks or anything. That lets you very quickly test all the possibly annotation forms with typos, spaces, etc.

I created a unit test for both kafka connect and MM2 annotation values with many cases to test the maximum of validations we can. Please take a look again.

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

…rator/assembly/KafkaMirrorMaker2AssemblyOperatorConnectorRestartTest.java Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

scholzj · 2025-09-10T23:26:01Z

+     * @return True if the provided resource has valid restart annotation. False otherwise.
+     * */
+    @SuppressWarnings({ "rawtypes" })
+    abstract boolean restartAnnotationIsValid(CustomResource resource, String connectorName);


HasMetadata here and its implementations as well?

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

…ka connector and mm2 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

scholzj

LGTM. Thanks for the changes. I left few more comments. But it looks mostly good.

scholzj · 2025-09-13T18:13:02Z

Hmm, I did not realize how complicated this would be. I wonder if we should make the methods static. But maybe we should leave that for some future refactoring.

In any case, I do not think there is any reason to have this in a separate file. I don't think we need so many separate test classes just for a single feature like this. Just move it to cluster-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/KafkaConnectAssemblyOperatorConnectorRestartTest.java maybe?

just moved it.

scholzj · 2025-09-13T18:13:35Z

Same as with the other file. I would move it to cluster-operator/src/test/java/io/strimzi/operator/cluster/operator/assembly/KafkaMirrorMaker2AssemblyOperatorConnectorRestartTest.java.

done @scholzj

scholzj

Two more nits. LGTM otherwise. Thanks for the work an patience.

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

…rator/assembly/AbstractConnectOperator.java Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

ppatierno

LGTM. Thanks!

PaulRMellor

I made a suggestion on the docs to include a bit more detail on the options and to format with the step

Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

katheris

Thanks for working on this PR @rlanhellas. The code look great, I just had a couple of test related questions which I added

katheris · 2025-09-17T09:13:47Z

+
+        op.maybeCreateOrUpdateConnector(Reconciliation.DUMMY_RECONCILIATION, "my-connect-host", mockConnectApi, "my-connector", connector.getSpec(), kafkaMirrorMaker2)
+                .onComplete(context.succeeding(r -> context.verify(() -> {
+                    verify(mockConnectApi, never()).restart(any(), anyInt(), any(), eq(false), eq(false));


Same here as the Connect tests, I think these arguments matches shouldn't check for eq(false)

PaulRMellor

Thanks for the updates

ppatierno · 2025-09-18T06:48:56Z

@rlanhellas do you have any ETA for the changes requested by Kate? The plan was to cut the 0.48.0 branch today and start the release process for RC1 and we would like to have this one included as planned. Thanks!

rlanhellas · 2025-09-18T11:30:06Z

My plan is to have it ready tomorrow morning, may we wait until tomorrow to cut the branch ? @ppatierno

ppatierno · 2025-09-18T12:08:52Z

My plan is to have it ready tomorrow morning, may we wait until tomorrow to cut the branch ? @ppatierno

@rlanhellas yeah sure no worries. I have got a "little" thing I would like to include in 0.48.0 so there is still time for it. But if you can do by tomorrow would be great, so when I am ready, I can just proceed with the release because yours work is already in.

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

…rator/assembly/KafkaConnectAssemblyOperatorConnectorRestartTest.java Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

katheris

Thanks for all your work on this @rlanhellas

ppatierno · 2025-09-22T11:45:55Z

/azp run regression

azure-pipelines · 2025-09-22T11:46:07Z

Azure Pipelines successfully started running 1 pipeline(s).

ppatierno added this to the 0.49.0 milestone Sep 1, 2025

ppatierno reviewed Sep 1, 2025

View reviewed changes

scholzj requested changes Sep 1, 2025

View reviewed changes

rlanhellas added 3 commits September 8, 2025 10:36

feat: enhance validation for restart annotations in Kafka connectors

66318c9

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

feat: enhance validation for restart annotations in Kafka connectors

5deae11

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

feat: improving connector restart args

85c3896

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

rlanhellas force-pushed the issue-11484 branch from d212b7d to 85c3896 Compare September 9, 2025 00:13

rlanhellas added 3 commits September 9, 2025 10:57

tests: connector restart with args

09837fa

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

tests: connector restart with args

b66a848

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

docs: connector restart with args

df9f746

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

scholzj reviewed Sep 9, 2025

View reviewed changes

rlanhellas and others added 5 commits September 9, 2025 21:19

Update Annotations.java

ae3bc01

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update KafkaMirrorMaker2AssemblyOperator.java

dce944f

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update cluster-operator/src/test/java/io/strimzi/operator/cluster/ope…

26f6ac2

…rator/assembly/KafkaMirrorMaker2AssemblyOperatorConnectorRestartTest.java Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

feat: removing regex to improve readability in the code

98ac310

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

test: improving tests with invalid args

a382a96

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

rlanhellas requested a review from scholzj September 10, 2025 18:13

scholzj reviewed Sep 10, 2025

View reviewed changes

Update KafkaConnectAssemblyOperator.java

44d9ea4

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

scholzj mentioned this pull request Sep 11, 2025

Restarting connectors and connevtor tasks in Connect and MM2 should be logged at INFO level #11762

Closed

rlanhellas added 2 commits September 13, 2025 10:38

test: adding test cases for validate annotation values in restart kaf…

0eccf8b

…ka connector and mm2 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

test: adding test cases for validate annotation values in restart kaf…

c0a4804

…ka connector and mm2 Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

rlanhellas requested a review from scholzj September 13, 2025 13:40

scholzj changed the title ~~feat: enhance validation for restart annotations in Kafka connectors~~ Allow configuring additional options when restarting connectors Sep 13, 2025

scholzj reviewed Sep 13, 2025

View reviewed changes

scholzj approved these changes Sep 15, 2025

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread ...tor/src/main/java/io/strimzi/operator/cluster/operator/assembly/AbstractConnectOperator.java Outdated

scholzj modified the milestones: 0.49.0, 0.48.0 Sep 15, 2025

scholzj requested review from PaulRMellor and ppatierno September 15, 2025 20:31

rlanhellas and others added 2 commits September 15, 2025 17:38

Update CHANGELOG.md

ccdb38e

Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update cluster-operator/src/main/java/io/strimzi/operator/cluster/ope…

5f7e4ac

…rator/assembly/AbstractConnectOperator.java Co-authored-by: Jakub Scholz <www@scholzj.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

ppatierno reviewed Sep 16, 2025

View reviewed changes

rlanhellas and others added 3 commits September 16, 2025 08:58

Update KafkaMirrorMaker2AssemblyOperator.java

827a81a

Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update KafkaMirrorMaker2AssemblyOperator.java

7ffac47

Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update CHANGELOG.md

6b6c85d

Co-authored-by: Paolo Patierno <paolo.patierno@gmail.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

ppatierno approved these changes Sep 16, 2025

View reviewed changes

PaulRMellor reviewed Sep 16, 2025

View reviewed changes

Comment thread documentation/modules/configuring/proc-manual-restart-connector.adoc Outdated

Comment thread documentation/modules/configuring/proc-manual-restart-mirrormaker2-connector.adoc Outdated

rlanhellas and others added 2 commits September 16, 2025 19:16

Update proc-manual-restart-mirrormaker2-connector.adoc

0fd307c

Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update proc-manual-restart-connector.adoc

62ffbc6

Co-authored-by: PaulRMellor <47596553+PaulRMellor@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

katheris reviewed Sep 17, 2025

View reviewed changes

PaulRMellor approved these changes Sep 17, 2025

View reviewed changes

test: moving tests to parameterized tests

36bd179

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

katheris reviewed Sep 22, 2025

View reviewed changes

Comment thread ...mzi/operator/cluster/operator/assembly/KafkaConnectAssemblyOperatorConnectorRestartTest.java

rlanhellas and others added 3 commits September 22, 2025 07:11

Update KafkaConnectAssemblyOperatorConnectorRestartTest.java

2451683

Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

Update cluster-operator/src/test/java/io/strimzi/operator/cluster/ope…

7f94597

…rator/assembly/KafkaConnectAssemblyOperatorConnectorRestartTest.java Co-authored-by: Kate Stanley <11195226+katheris@users.noreply.github.com> Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

feat: adding anyBoolean() to restart tests

1f3c544

Signed-off-by: Ronaldo Lanhellas <ronaldo.lanhellas@gmail.com>

katheris approved these changes Sep 22, 2025

View reviewed changes

ppatierno merged commit 981aa58 into strimzi:main Sep 23, 2025
31 checks passed

im-konge mentioned this pull request Dec 12, 2025

[Enhancement]: Implement Kafka Connector /restart query parameters #11484

Closed

		private static final Pattern STRIMZI_IO_RESTART_ARGS_PATTERN = Pattern.compile("^includeTasks," +
		"onlyFailed$\|^onlyFailed,includeTasks$\|^includeTasks$\|^onlyFailed$\|^true$");

Conversation

rlanhellas commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description

Checklist

Uh oh!

ppatierno commented Sep 1, 2025

Uh oh!

ppatierno left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlanhellas commented Sep 1, 2025

Uh oh!

rlanhellas commented Sep 1, 2025

Uh oh!

scholzj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Sep 9, 2025 • edited by codecov Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rlanhellas commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scholzj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

rlanhellas commented Sep 1, 2025 •

edited

Loading

codecov-commenter commented Sep 9, 2025 •

edited by codecov Bot

Loading

rlanhellas commented Sep 9, 2025 •

edited

Loading