Skip to content

Avoid recomputing residual norms for MG early exit #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcarruscag wants to merge 54 commits into
base: develop
Choose a base branch
from
Open

Avoid recomputing residual norms for MG early exit #2786

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
d1e5d59
cleanup
pcarruscag Apr 12, 2026
62ad49c
fix
pcarruscag Apr 13, 2026
dd8b29f
check that we can recover the current behavior
pcarruscag Apr 13, 2026
31b0421
Revert "check that we can recover the current behavior"
pcarruscag Apr 13, 2026
768b781
fix regressions
bigfooted Apr 13, 2026
6a86303
fix regressions
bigfooted Apr 14, 2026
6e1d9e5
Apply suggestions from code review
bigfooted Apr 14, 2026
cb81b12
Apply suggestions from code review
bigfooted Apr 14, 2026
7b8b7bb
update regression residual
bigfooted Apr 14, 2026
671a0c8
fixed_cl first one
bigfooted Apr 14, 2026
f0b5c20
fix more
bigfooted Apr 14, 2026
953bff9
fix more
bigfooted Apr 15, 2026
1577b02
first update
bigfooted Apr 22, 2026
09c3a64
precompute residual
bigfooted Apr 22, 2026
bd45320
update on different residual strategies
bigfooted Apr 30, 2026
708c8b2
good convergence on 1_2DZP
bigfooted Apr 30, 2026
1fd247b
working with reasonable convergence
bigfooted May 1, 2026
1586663
1_2DZP converges in 1600 iterations
bigfooted May 1, 2026
5543d6a
merge with develop
bigfooted May 3, 2026
42e9247
cleanup
bigfooted May 3, 2026
07a4781
merge w develop
bigfooted May 3, 2026
6c08563
remove linsysrmsres
bigfooted May 3, 2026
5f81ac6
further simplification
bigfooted May 3, 2026
ad764cf
reduce to single residual mg analysis
bigfooted May 3, 2026
b5182ea
case 1,2 converge well
bigfooted May 3, 2026
e60d45f
improved MG CFL cap
bigfooted May 4, 2026
15db526
change const to constexpr
bigfooted May 4, 2026
cb12de3
Potential fix for pull request finding 'CodeQL / Commented-out code'
bigfooted May 4, 2026
987af06
Potential fix for pull request finding 'CodeQL / Commented-out code'
bigfooted May 4, 2026
eeef043
ditch the defect correction tests
bigfooted May 4, 2026
90795e7
Merge branch 'pedro/use_available_residual' of https://github.com/su2…
bigfooted May 4, 2026
b6ac379
synch mlpcpp
bigfooted May 4, 2026
886e2d2
Potential fix for pull request finding 'CodeQL / Commented-out code'
bigfooted May 4, 2026
2b50f85
cleanup comments
bigfooted May 4, 2026
7d27bc9
Merge branch 'pedro/use_available_residual' of https://github.com/su2…
bigfooted May 4, 2026
963e12d
change passivedouble
bigfooted May 4, 2026
b0472e3
fix AD compile error
bigfooted May 4, 2026
31752de
simple scaling for coarse meshes
bigfooted May 5, 2026
b01702a
CODI fix
bigfooted May 5, 2026
8373167
remove mg cfl
bigfooted May 5, 2026
9f4ae4f
Merge branch 'develop' into pedro/use_available_residual
bigfooted May 24, 2026
16be471
implicit_lines config option
bigfooted May 24, 2026
351c023
Merge branch 'pedro/use_available_residual' of https://github.com/su2…
bigfooted May 24, 2026
7cebbb7
cleanup multigrid, simplify damping
bigfooted May 25, 2026
cd678b8
precommit
bigfooted May 25, 2026
3306b81
remove template for damping factor
bigfooted May 25, 2026
1721cf0
cleanup the damping factor adaptation
bigfooted May 29, 2026
83fff8e
Merge branch 'develop' into pedro/use_available_residual
bigfooted May 31, 2026
567297c
change config_template and default value for damping
bigfooted May 31, 2026
9a57a1f
Merge branch 'pedro/use_available_residual' of https://github.com/su2…
bigfooted May 31, 2026
db86086
fix most regression values
bigfooted Jun 7, 2026
ee79c18
fix some file diffs
bigfooted Jun 8, 2026
7aba679
fix the rest
bigfooted Jun 8, 2026
5a78f21
fix regression file
bigfooted Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 0 additions & 63 deletions SU2_CFD/include/integration/ComputeLinSysResRMS.hpp
View file
Open in desktop

This file was deleted.

234 changes: 110 additions & 124 deletions SU2_CFD/src/integration/CMultiGridIntegration.cpp
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion SU2_CFD/src/solvers/CSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1963,7 +1963,7 @@ void CSolver::AdaptCFLNumber(CGeometry **geometry,
void CSolver::SetResidual_RMS(const CGeometry *geometry, const CConfig *config) {
SU2_ZONE_SCOPED

if (geometry->GetMGLevel() != MESH_0) return;
if (geometry->GetMGLevel() != MESH_0 && !config->GetMGOptions().MG_Smooth_EarlyExit) return;
Comment thread
pcarruscag marked this conversation as resolved.

BEGIN_SU2_OMP_SAFE_GLOBAL_ACCESS {

Expand Down
76 changes: 38 additions & 38 deletions TestCases/cont_adj_euler/naca0012/of_grad_cd.dat.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,39 @@
VARIABLES="VARIABLE" , "GRADIENT" , "FINDIFF_STEP"
0 , -0.346339 , 0.0001
1 , -0.248052 , 0.0001
2 , -0.1713 , 0.0001
3 , -0.122543 , 0.0001
4 , -0.101101 , 0.0001
5 , -0.104377 , 0.0001
6 , -0.127816 , 0.0001
7 , -0.164567 , 0.0001
8 , -0.206037 , 0.0001
9 , -0.24378 , 0.0001
10 , -0.272396 , 0.0001
11 , -0.292059 , 0.0001
12 , -0.308757 , 0.0001
13 , -0.331226 , 0.0001
14 , -0.366529 , 0.0001
15 , -0.418919 , 0.0001
16 , -0.495353 , 0.0001
17 , -0.619083 , 0.0001
18 , -0.889061 , 0.0001
19 , 0.118474 , 0.0001
20 , 0.849882 , 0.0001
21 , 1.3251 , 0.0001
22 , 1.53508 , 0.0001
23 , 1.51368 , 0.0001
24 , 1.31908 , 0.0001
25 , 1.02001 , 0.0001
26 , 0.68317 , 0.0001
27 , 0.363758 , 0.0001
28 , 0.100704 , 0.0001
29 , -0.0830333 , 0.0001
30 , -0.176826 , 0.0001
31 , -0.178825 , 0.0001
32 , -0.096525 , 0.0001
33 , 0.0472928 , 0.0001
34 , 0.21134 , 0.0001
35 , 0.355622 , 0.0001
36 , 0.490104 , 0.0001
37 , 0.718618 , 0.0001
0 , -3129.83 , 0.001
1 , -11358.3 , 0.001
2 , -14484.0 , 0.001
3 , -14330.8 , 0.001
4 , -12608.7 , 0.001
5 , -10550.0 , 0.001
6 , -8889.13 , 0.001
7 , -7943.27 , 0.001
8 , -7729.55 , 0.001
9 , -8089.35 , 0.001
10 , -8803.82 , 0.001
11 , -9689.36 , 0.001
12 , -10673.2 , 0.001
13 , -11870.0 , 0.001
14 , -13689.4 , 0.001
15 , -16954.6 , 0.001
16 , -23081.3 , 0.001
17 , -35877.8 , 0.001
18 , -71117.5 , 0.001
19 , -17877.2 , 0.001
20 , -22149.1 , 0.001
21 , -18300.4 , 0.001
22 , -12702.7 , 0.001
23 , -8337.57 , 0.001
24 , -6019.84 , 0.001
25 , -5270.34 , 0.001
26 , -4986.92 , 0.001
27 , -3951.65 , 0.001
28 , -1206.3 , 0.001
29 , 3646.51 , 0.001
30 , 10149.0 , 0.001
31 , 16714.8 , 0.001
32 , 20678.6 , 0.001
33 , 19464.5 , 0.001
34 , 13560.5 , 0.001
35 , 8716.09 , 0.001
36 , 9495.39 , 0.001
37 , 14681.0 , 0.001
6 changes: 3 additions & 3 deletions TestCases/cont_adj_euler/naca0012/of_grad_directdiff.dat.ref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VARIABLES="VARIABLE" , "DRAG" , "EFFICIENCY" , "FORCE_X" , "FORCE_Y" , "FORCE_Z" , "LIFT" , "MOMENT_X" , "MOMENT_Y" , "MOMENT_Z" , "SIDEFORCE"
0 , 0.05240962543 , -27.33945591 , 0.08647516198 , -1.560629715 , 0.0 , -1.562144773 , 0.0 , 0.0 , 0.8858124377 , 0.0
1 , 0.2008795877 , -41.40890891 , 0.2463424389 , -2.081341632 , 0.0 , -2.086220261 , 0.0 , 0.0 , 0.737429107 , 0.0
2 , 0.371975273 , -55.04424867 , 0.4271103196 , -2.522745633 , 0.0 , -2.531462651 , 0.0 , 0.0 , 0.4069664819 , 0.0
0 , 0.08545925082 , -29.66992584 , 0.119474273 , -1.557954145 , 0.0 , -1.560189712 , 0.0 , 0.0 , 0.893137395 , 0.0
1 , 0.2201968158 , -43.87838086 , 0.2655030157 , -2.073951675 , 0.0 , -2.079250049 , 0.0 , 0.0 , 0.7622913414 , 0.0
2 , 0.3777725459 , -57.65606719 , 0.4325932101 , -2.508274445 , 0.0 , -2.517114515 , 0.0 , 0.0 , 0.4420784146 , 0.0
Loading
Loading