Skip to content

Enable viscous flux contribution at supersonic outlet boundary condition #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yiluntam wants to merge 5 commits into
base: develop
Choose a base branch
from
+142 −38
Open

Enable viscous flux contribution at supersonic outlet boundary condition #2829

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc15466
Merge pull request #2804 from su2code/develop
pcarruscag Apr 28, 2026
092f23a
Enable viscous flux contribution at supersonic outlet boundary condition
yiluntam Jun 10, 2026
cd4bb21
Fix: declare Point_Normal in BC_Supersonic_Outlet viscous section
yiluntam Jun 12, 2026
0d64672
Merge branch 'develop' into fix/euler-outlet-bc
bigfooted Jun 12, 2026
82d8e59
Add laminar flat plate test case config (Ma=4.0, Re=1.2e4)
yiluntam Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 40 additions & 38 deletions SU2_CFD/src/solvers/CEulerSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7514,6 +7514,7 @@
su2double *V_outlet, *V_domain;

bool implicit = (config->GetKind_TimeIntScheme() == EULER_IMPLICIT);
bool viscous = config->GetViscous();
string Marker_Tag = config->GetMarker_All_TagBound(val_marker);

auto *Normal = new su2double[nDim];
Expand Down Expand Up @@ -7578,44 +7579,45 @@
if (implicit)
Jacobian.AddBlock2Diag(iPoint, residual.jacobian_i);

// /*--- Viscous contribution, commented out because serious convergence problems ---*/
//
// if (viscous) {
//
// /*--- Set laminar and eddy viscosity at the infinity ---*/
//
// V_outlet[nDim+5] = nodes->GetLaminarViscosity(iPoint);
// V_outlet[nDim+6] = nodes->GetEddyViscosity(iPoint);
//
// /*--- Set the normal vector and the coordinates ---*/
//
// visc_numerics->SetNormal(Normal);
// su2double Coord_Reflected[MAXNDIM];
// GeometryToolbox::PointPointReflect(nDim, geometry->nodes->GetCoord(Point_Normal),
// geometry->nodes->GetCoord(iPoint), Coord_Reflected);
// visc_numerics->SetCoord(geometry->nodes->GetCoord(iPoint), Coord_Reflected);
//
// /*--- Primitive variables, and gradient ---*/
//
// visc_numerics->SetPrimitive(V_domain, V_outlet);
// visc_numerics->SetPrimVarGradient(nodes->GetGradient_Primitive(iPoint), nodes->GetGradient_Primitive(iPoint));
//
// /*--- Turbulent kinetic energy ---*/
//
// if (config->GetKind_Turb_Model() == TURB_MODEL::SST)
// visc_numerics->SetTurbKineticEnergy(solver_container[TURB_SOL]->GetNodes()->GetSolution(iPoint,0),
// solver_container[TURB_SOL]->GetNodes()->GetSolution(iPoint,0));
//
// /*--- Compute and update residual ---*/
//
// auto residual = visc_numerics->ComputeResidual(config);
// LinSysRes.SubtractBlock(iPoint, residual);
//
// /*--- Jacobian contribution for implicit integration ---*/
//
// if (implicit)
// Jacobian.SubtractBlock2Diag(iPoint, residual.jacobian_i);
// }
/*--- Viscous contribution, commented out because serious convergence problems ---*/

if (viscous) {

/*--- Set laminar and eddy viscosity at the infinity ---*/

V_outlet[nDim+5] = nodes->GetLaminarViscosity(iPoint);
V_outlet[nDim+6] = nodes->GetEddyViscosity(iPoint);

/*--- Set the normal vector and the coordinates ---*/

visc_numerics->SetNormal(Normal);
su2double Coord_Reflected[MAXNDIM];
unsigned long Point_Normal = geometry->vertex[val_marker][iVertex]->GetNormal_Neighbor();
GeometryToolbox::PointPointReflect(nDim, geometry->nodes->GetCoord(Point_Normal),
geometry->nodes->GetCoord(iPoint), Coord_Reflected);
visc_numerics->SetCoord(geometry->nodes->GetCoord(iPoint), Coord_Reflected);

/*--- Primitive variables, and gradient ---*/

visc_numerics->SetPrimitive(V_domain, V_domain);
visc_numerics->SetPrimVarGradient(nodes->GetGradient_Primitive(iPoint), nodes->GetGradient_Primitive(iPoint));

/*--- Turbulent kinetic energy ---*/

if (config->GetKind_Turb_Model() == TURB_MODEL::SST)
visc_numerics->SetTurbKineticEnergy(solver_container[TURB_SOL]->GetNodes()->GetSolution(iPoint,0),
solver_container[TURB_SOL]->GetNodes()->GetSolution(iPoint,0));

/*--- Compute and update residual ---*/

auto residual = visc_numerics->ComputeResidual(config);

Check notice

Code scanning / CodeQL

Declaration hides variable Note

Variable residual hides another variable of the same name (on
line 7573
Loading
).
Comment thread
yiluntam marked this conversation as resolved.
Comment thread
yiluntam marked this conversation as resolved.
LinSysRes.SubtractBlock(iPoint, residual);

/*--- Jacobian contribution for implicit integration ---*/

if (implicit)
Jacobian.SubtractBlock2Diag(iPoint, residual.jacobian_i);
}

}
}
Expand Down
Loading