Added unit tests that mimics a dynamic spectra#931
Open
nabobalis wants to merge 6 commits into
Open
Conversation
nabobalis
commented
May 20, 2026
| # Use the to_pixel methods to preserve fractional indices for future rounding. | ||
| point_pixel_indices = (sliced_wcs.world_to_pixel_values(*sliced_point) if crop_by_values | ||
| else HighLevelWCSWrapper(sliced_wcs).world_to_pixel(*sliced_point)) | ||
| if crop_by_values: |
Member
Author
There was a problem hiding this comment.
I am not sure if this is quite true but it did break a unit test.
Member
Author
There was a problem hiding this comment.
This is a real regression in the oldest deps, gwcs looks like it used to handle this internally?!
nabobalis
force-pushed
the
tests
branch
2 times, most recently
from
988196d to
356f99f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comes with a bugfix(?).
SPOILER: AI WAS USED but code was human reviewed and edited.